This repository was archived by the owner on Sep 2, 2026. It is now read-only.
Repository navigation
chore(deps): bump react to 19.2.8 to satisfy react-dom peer range - #31
Merged
Merged
Conversation
PR #10 bumped react-dom to 19.2.8 but left react pinned at 19.2.4. react-dom 19.2.8 declares `peer react@"^19.2.8"`, so `npm ci` fails with ERESOLVE on main and no dependency tree can be resolved. Bumps react to 19.2.8 so the peer range is satisfied again. Verified locally: npm ci, tsc --noEmit, eslint and next build all pass.
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #10 bumped
react-domto19.2.8but leftreactpinned at19.2.4.[email protected]declarespeer react@"^19.2.8", so on currentmain:npm cifails outright — no dependency tree resolves, so nothing can beinstalled, built or linted.
Fix
Bump
reactto19.2.8so the peer range is satisfied again.Verification
All run locally against this branch (
react19.2.8 /react-dom19.2.8):npm cinpx tsc --noEmitnpx eslintnpx next buildNote
The repo currently has no build/lint/typecheck CI — only CodeQL. That is why
this peer conflict reached
mainwithout any check going red. Worth adding aCI workflow that runs
npm ci && npm run lint && npm run build.Follow-up to #10.