Repository navigation
Prevent Windows CRLF image health failures and document published artifacts - #13
Merged
Merged
Conversation
shellharbor
marked this pull request as ready for review
October 28, 2026 14:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows checkout/archive conversion changed the published nginx health response from LF to CRLF. HTTP checks stripped the response and missed that Docker's exact HEALTHCHECK never became healthy.
Require LF for standalone Docker assets and add a real nginx Docker health-state regression without a database. The new test reproduces failure of the original Windows-built image and passes for the corrected nginx-r1 built from the unchanged v1.2.0 Git source with core.autocrlf=false. Real Moodle/PostgreSQL integration also passes with r1 (two checks, 184.139 seconds).
Update README/runtime/Python/release guides to the published 1.2.0 distributions and corrected nginx-r1 tag. Record verified registry digests, fresh public PyPI/native toolkit installation, successful CI/E2E and scoped owner-approved security settings in continuity documents. Existing published tags are retained; the original nginx tag is explicitly superseded in the release notes.
Docker Hub and PyPI publication are verified. This PR prevents repeat Windows packaging failures and makes the public documentation reflect the published artifacts.
Final verification: all 26 PR checks pass, including the four real image tests in GitHub run 40701292273. Explicit Windows autocrlf=true checkout preserves the LF health payload. Public Docker Hub app/nginx-r1 digests match the tested images; public PyPI/native installation is verified. Final local build cache is 0 B after removing 7.006 GB across the two cleanups.