Document the --fast skip contract - #3
Merged
Merged
Conversation
added 2 commits
August 29, 2026 22:51
…wire. An in-place edit that keeps size and mtime is skipped on purpose; verify still fails, and a non-fast sync repairs it.
Python's second-resolution utime made --fast rehash, so the skip assertion failed on the lab VM even though the contract is intact.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--fastskips a same-size, same-mtime in-place edit and leaves the drifted bytes in place.verifyafter a--fastresync.--fasthole on live sshd.Test plan
go test ./internal/receiver -run Fastgo test ./internal/protocol -run DestUnhashablego test ./..../scripts/e2e-live.shon quikagent-lab