style: reformat for prettier 3.9 - #41
Merged
Merged
Conversation
PR #38 raised prettier from 3.7.4 to 3.9.6 as one of twenty-three backend dependency updates. 3.9 formats short union types on a single line rather than the leading-pipe multiline style 3.7 produced, which left five existing files failing `prettier --check` the moment #38 landed. No workflow runs check-format -- the deploy workflows run lint and tests only -- so nothing in CI reported it. The gate that catches this is the pre-push hook, which means the first person to push anything to acc would have hit a format failure in files they had not touched. Purely cosmetic: five files, +5/-22, produced by `npm run format` and reviewed as a diff. Lint passes, backend 1130/1130, frontend 573/573, check-format back to exit 0. Kept as its own commit rather than folded into the release that follows, so the reformat stays attributable to the prettier upgrade that caused it instead of being buried among twenty-five unrelated commits.
|
Azure Static Web Apps: Your stage site is ready! Visit it here: https://brave-bay-04f351e03-41.westeurope.4.azurestaticapps.net |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #38.
That PR raised prettier
3.7.4→3.9.6as one of twenty-three backenddependency updates. 3.9 formats short union types on a single line rather than
the leading-pipe multiline style 3.7 produced, so five existing files began
failing
prettier --checkthe moment #38 landed:Why CI didn't catch it
No workflow runs
check-format. The deploy workflows runnpm run lintandnpm test; the audit gate runs zizmor and the Renovate config validator. Thecheck that catches this is the pre-push hook — so the symptom would have
been the next person's
git pushfailing on files they never touched.Worth noting as a gap in its own right:
check-formatis enforced locally butnot in CI, which is the wrong way round for a rule meant to hold on the shared
branch.
This change
Purely cosmetic — 5 files, +5/−22, produced by
npm run formatand reviewedas a diff rather than taken on trust.
npm run check-formatnpm run lintnpm run buildKept as its own commit rather than folded into the v2026.08.4 release that
follows, so the reformat stays attributable to the upgrade that caused it
instead of being buried among twenty-five unrelated commits.