Repository navigation
Conversation
Owner
Author
|
Superseded by #55: the same fix landed in release/v0.9.0 with it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the red
Checkon #47 (macos-latest, windows-2022):steam activities > another game launches and runs while one downloadstimed out waiting fornotify:game-installed.Cause
A real bug, not a test flake. When the Steam poll reads an
appmanifest_<appid>.acfwhile it is being rewritten (truncated, noStateFlagsyet),readAcfStatereturnednull, which the batch lookup reported asabsent. The watch then sawdownloading → absent → installedinstead ofdownloading → installed: the activity flickered and the "installed" notification was lost (absent → installedis "installed in Steam directly", which deliberately does not notify). The test rewrites the.acfwith a plainwriteFile, so the slower macOS/Windows runners hit the window; Steam rewriting its own manifests can hit it the same way.Fix
readAcfStatetells a missing.acffrom an unparseable one.steamInstallStatusesleaves an appid whose.acfcould not be parsed out of the map, andSteamActivityWatchkeeps what it last knew for it.steamInstallStatus(used forGameInfo) still reads it asabsent, as before..acfcaught mid-rewrite changes nothing, and the finished download still notifies.The rest of the diff in the two files is Prettier formatting carried over from the feature branch, where this fix already lives (it will merge cleanly with the next per-game-activity PR).
Verification
typecheck,lintandvitest(1395 passed, three runs in a row) onrelease/v0.9.0+ this change.