Repository navigation
Conversation
password() assumed a ':' at username_end could not be a port because
the host cannot be empty. set_host("") is allowed on non-special URLs
and can leave a serialization such as sc://:12/, so that colon is the
port and the old slice was inverted.
Require a terminating '@' before treating the colon as a password
separator.
Fixes servo#1174
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Calling
set_host(Some(\"\"))on a non-special URL such assc://test:12/is allowed and can producesc://:12/.password()then treated the port:as a password separator, because it assumed a host cannot be empty, and panicked with an inverted slice range (byte range starts at 6 but ends at 4).The method now requires the userinfo to be terminated by
@before taking a password slice, sopassword()returnsNoneforsc://:12/and still returns the password when@is present.Fixes #1174