Repository navigation
Reject lossy WASI file path conversions - #1158
Open
JustYannicc wants to merge 3 commits into
Open
JustYannicc wants to merge 3 commits into
JustYannicc wants to merge 3 commits into
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On WASI,
Url::from_file_pathcurrently returnsOkafter replacing invalid UTF-8 filename bytes with U+FFFD. For example, the WASIp1 pathb"/foo/ba\x80r"becomesfile:///foo/ba%EF%BF%BDr, so converting it back addresses a different filename.Reject invalid UTF-8 in the WASI encoder, consistent with the existing WASI decoder. This keeps the stable WASIp2 support from #983 and avoids a new dependency on WASIp2's unstable
std::os::wasiAPIs. Native platform behavior is unchanged. The regression constructs the invalid path in memory; no filesystem access is needed.Validation with Rust 1.95.0:
new_path_bad_utf8test passes.Commands:
Run the WASIp1 binary with the following Node script, passing its path as the first argument:
Implemented with GPT 6.1 Sol through the Codex harness.