Repository navigation
Prepare Codex Pets v1.0.0 release - #20
Merged
Merged
Conversation
📝 WalkthroughWalkthroughAdds a deterministic Python renderer for Codex Pets V1 lab GIF/PNG assets, publishes v1.0.0 release documentation, promotes GitHub starring in the README and site navigation, and ignores additional macOS artifacts. ChangesV1 release presentation
Estimated code review effort: 4 (Complex) | ~45 minutes Sequence Diagram(s)sequenceDiagram
participant CLI
participant Catalogue
participant Renderer
participant OutputFiles
CLI->>Catalogue: Load and validate published pet metadata
Catalogue->>Renderer: Provide verified spritesheets and preview frames
Renderer->>Renderer: Compose static and animated lab frames
Renderer->>OutputFiles: Write the GIF and PNG assets
Possibly related PRs
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
senyo888
marked this pull request as ready for review
July 15, 2026 18:15
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@scripts/build_lab_header.py`:
- Around line 329-336: Update the progress calculation in the correction
rendering block to be monotonically increasing throughout the 6.72-second loop,
replacing the cosine-based oscillation derived from phase with a one-way
phase-to-progress mapping. Preserve the existing color thresholds and rounded
rectangle drawing in the surrounding correction_draw logic.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 064219ad-9f6e-4a91-9514-23f59ee5ebcf
⛔ Files ignored due to path filters (2)
docs/releases/assets/codex-pets-v1-lab-static.pngis excluded by!**/*.pngdocs/releases/assets/codex-pets-v1-lab.gifis excluded by!**/*.gif
📒 Files selected for processing (6)
.gitignoreREADME.mddocs/releases/v1.0.0.mdscripts/build_lab_header.pysite/index.htmlsite/styles.css
Comment on lines
+329
to
+336
| # Calian traces the fault; Scarlet closes it. The status moves steadily | ||
| # from scarlet through gold to green over the complete 6.72-second loop. | ||
| correction = rgba_layer() | ||
| correction_draw = ImageDraw.Draw(correction) | ||
| progress = 0.18 + 0.76 * (0.5 - 0.5 * math.cos(phase * math.tau)) | ||
| correction_draw.rounded_rectangle((978, 348, 1156, 361), radius=6, fill=(4, 15, 26, 220), outline=(*VIOLET, 50)) | ||
| progress_color = GREEN if progress > 0.72 else GOLD if progress > 0.42 else SCARLET | ||
| correction_draw.rounded_rectangle((981, 351, 981 + round(172 * progress), 358), radius=3, fill=(*progress_color, 152)) |
There was a problem hiding this comment.
🎯 Functional Correctness | 🟡 Minor | ⚡ Quick win
Make the correction progress one-way.
The cosine curve reverses after the midpoint, so the status moves scarlet → green → scarlet rather than steadily reaching closure.
Proposed fix
- progress = 0.18 + 0.76 * (0.5 - 0.5 * math.cos(phase * math.tau))
+ progress = 0.18 + 0.76 * phase📝 Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.
Suggested change
| # Calian traces the fault; Scarlet closes it. The status moves steadily | |
| # from scarlet through gold to green over the complete 6.72-second loop. | |
| correction = rgba_layer() | |
| correction_draw = ImageDraw.Draw(correction) | |
| progress = 0.18 + 0.76 * (0.5 - 0.5 * math.cos(phase * math.tau)) | |
| correction_draw.rounded_rectangle((978, 348, 1156, 361), radius=6, fill=(4, 15, 26, 220), outline=(*VIOLET, 50)) | |
| progress_color = GREEN if progress > 0.72 else GOLD if progress > 0.42 else SCARLET | |
| correction_draw.rounded_rectangle((981, 351, 981 + round(172 * progress), 358), radius=3, fill=(*progress_color, 152)) | |
| # Calian traces the fault; Scarlet closes it. The status moves steadily | |
| # from scarlet through gold to green over the complete 6.72-second loop. | |
| correction = rgba_layer() | |
| correction_draw = ImageDraw.Draw(correction) | |
| progress = 0.18 + 0.76 * phase | |
| correction_draw.rounded_rectangle((978, 348, 1156, 361), radius=6, fill=(4, 15, 26, 220), outline=(*VIOLET, 50)) | |
| progress_color = GREEN if progress > 0.72 else GOLD if progress > 0.42 else SCARLET | |
| correction_draw.rounded_rectangle((981, 351, 981 + round(172 * progress), 358), radius=3, fill=(*progress_color, 152)) |
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@scripts/build_lab_header.py` around lines 329 - 336, Update the progress
calculation in the correction rendering block to be monotonically increasing
throughout the 6.72-second loop, replacing the cosine-based oscillation derived
from phase with a one-way phase-to-progress mapping. Preserve the existing color
thresholds and rounded rectangle drawing in the surrounding correction_draw
logic.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Scope
Reason
Prepare a reviewable first stable release package and give visitors one clear route to support the community catalogue on GitHub.
Files affected
README.mddocs/releases/v1.0.0.mddocs/releases/assets/codex-pets-v1-lab.gifdocs/releases/assets/codex-pets-v1-lab-static.pngscripts/build_lab_header.pysite/index.htmlsite/styles.cssRuntime impact
None. Pet runtime behavior, package metadata, installer routes, entity semantics, and deterministic control paths do not change. The site badge is plain HTML/CSS and adds no JavaScript or runtime API request.
UI impact
★ Give us a starbadge that points to the repository page.1200 x 560, 24 frames, 6.72 seconds, and loops indefinitely; the static PNG remains the reduced-motion fallback.UI truth consistency risk is low: the star shield is supplied by GitHub/Shields, and all seven pets in the release header are composited from tracked preview frames with no generated or redrawn pet artwork.
Migration impact
None. No migration, restart, refresh, or dashboard export is required. GitHub Pages will pick up the site change after merge and deployment.
Validation performed
.codex/scripts/project_preflight.sh— passed: 7 published pets, 61 site references, 81 Markdown references.python3 scripts/validate_catalog.py— passed.python3 .codex/scripts/privacy_scan.py— passed: 84 public candidates, 0 matches.1200 x 560, 24 frames, 6720 ms, infinite loop, opaque background, 1,516,614 bytes.1200 x 560, RGB, opaque background, 276,581 bytes.scrollWidth=390, nav358/358, badge fully visible, 0 console warnings/errors.git diff --checkand staged diff checks — passed.Deterministic lane-ordering risk: none. No runtime decisions or control paths are touched.
Rollback safety
Revert
a877cdaand47404e4to remove only the star calls-to-action. Revert3b0b339to remove the release-preparation files. The separate GitHub release remains a draft and can be deleted without affecting packages, the catalogue, or published runtime behavior.Summary by CodeRabbit
New Features
Style
Chores