Repository navigation
Fix result-variable column order and keep them on column reset - #182
Merged
Merged
Conversation
…ot and keep them on column reset
ramonski
approved these changes
Jul 17, 2026
ramonski
left a comment
Contributor
There was a problem hiding this comment.
Thanks! Encountered that but as well recently
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the issue/feature this PR addresses
Analysis services that define result variables (interim fields) contribute extra columns to the analyses listing. These columns are dynamic: they don't exist in the static column set and are created server-side only while building the folderitems, then inserted at the Result/AdditionalValues position of each review_states[].columns.
The ReactJS listing, however, derives the visible column order from the localStorage-backed merged config (_merged_column_config → merge_column_config), which:
As a result the columns are visible but always ordered last. A second, related defect: resetColumns restores @state.columns from @root_el.dataset.columns — the page-render DOM snapshot captured before the folderitems ran — which contains none of the dynamic columns.
Reproducible with any service that has result variables (independent of result type or add-on).
Current behavior before PR
Desired behavior after PR is merged
Changes
--
I confirm I have tested the PR thoroughly and coded it according to PEP8
standards.