Backport release/v6.6: Remove redundant libstdc++6 installation - #3848
Backport release/v6.6: Remove redundant libstdc++6 installation#3848seidroid[bot] wants to merge 1 commit into
release/v6.6: Remove redundant libstdc++6 installation#3848Conversation
Ubuntu 24.04’s runtime image already includes a distro-provided libstdc++6 with GLIBCXX_3.4.32 support. Remove the redundant explicit installation while retaining CA certificate setup. (cherry picked from commit 1ecc672)
PR SummaryLow Risk Overview The final Ubuntu runtime stage no longer installs Reviewed by Cursor Bugbot for commit cac4c0b. Bugbot is set up for automated code reviews on this repo. Configure here. |
|
The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).
|
There was a problem hiding this comment.
LGTM — this is a straightforward backport of an already-merged, running change on main (cac4c0b3, PR #3847).
Extended reasoning...
Overview
The PR is a pure backport to release/v6.6 of commit cac4c0b (PR #3847), which is already merged and live on main. It removes libstdc++6 from the final apt-get install line in the Ubuntu runtime stage of the Dockerfile, leaving only ca-certificates. No other lines change.
Security risks
None. This only trims an unused runtime package from the container image; it does not touch application logic, permissions, credentials, or network-facing code.
Level of scrutiny
Minimal scrutiny is warranted. This is a mechanical, single-line Dockerfile change that mirrors a change already validated and running on main, so there is no new risk surface introduced by the backport itself. The main question — whether the Giga executor's libevmone.so still loads without libstdc++6 — was already exercised on main since PR #3847 merged, and a verifier in this run separately checked and ruled out dynamic-loading breakage.
Other factors
Single-file, single-line diff; no logic or test changes needed. No unresolved reviewer comments in the timeline (only an informational Cursor Bugbot summary).
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release/v6.6 #3848 +/- ##
================================================
- Coverage 59.01% 58.13% -0.89%
================================================
Files 2225 2151 -74
Lines 183562 174994 -8568
================================================
- Hits 108323 101726 -6597
+ Misses 65493 64223 -1270
+ Partials 9746 9045 -701
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
Backport of #3847 to
release/v6.6.