Skip to content

Backport release/v6.6: Remove redundant libstdc++6 installation - #3848

Open
seidroid[bot] wants to merge 1 commit into
release/v6.6from
backport-3847-to-release/v6.6
Open

Backport release/v6.6: Remove redundant libstdc++6 installation#3848
seidroid[bot] wants to merge 1 commit into
release/v6.6from
backport-3847-to-release/v6.6

Conversation

@seidroid

@seidroid seidroid Bot commented Aug 4, 2026

Copy link
Copy Markdown

Backport of #3847 to release/v6.6.

Ubuntu 24.04’s runtime image already includes a distro-provided
libstdc++6 with GLIBCXX_3.4.32 support. Remove the redundant explicit
installation while retaining CA certificate setup.

(cherry picked from commit 1ecc672)
@cursor

cursor Bot commented Aug 4, 2026

Copy link
Copy Markdown

PR Summary

Low Risk
Single-package removal from the runtime container build; no application or chain logic changes.

Overview
Backport of #3847 to release/v6.6.

The final Ubuntu runtime stage no longer installs libstdc++6 alongside ca-certificates; only ca-certificates is kept in the apt-get install line. This trims the image without changing how seid, seictl, or the copied .so libraries are laid out.

Reviewed by Cursor Bugbot for commit cac4c0b. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

The latest Buf updates on your PR. Results from workflow Buf / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedAug 4, 2026, 1:54 PM

@claude claude Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM — this is a straightforward backport of an already-merged, running change on main (cac4c0b3, PR #3847).

Extended reasoning...

Overview

The PR is a pure backport to release/v6.6 of commit cac4c0b (PR #3847), which is already merged and live on main. It removes libstdc++6 from the final apt-get install line in the Ubuntu runtime stage of the Dockerfile, leaving only ca-certificates. No other lines change.

Security risks

None. This only trims an unused runtime package from the container image; it does not touch application logic, permissions, credentials, or network-facing code.

Level of scrutiny

Minimal scrutiny is warranted. This is a mechanical, single-line Dockerfile change that mirrors a change already validated and running on main, so there is no new risk surface introduced by the backport itself. The main question — whether the Giga executor's libevmone.so still loads without libstdc++6 — was already exercised on main since PR #3847 merged, and a verifier in this run separately checked and ruled out dynamic-loading breakage.

Other factors

Single-file, single-line diff; no logic or test changes needed. No unresolved reviewer comments in the timeline (only an informational Cursor Bugbot summary).

@codecov

codecov Bot commented Aug 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 58.13%. Comparing base (c0f9682) to head (cac4c0b).

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff                @@
##           release/v6.6    #3848      +/-   ##
================================================
- Coverage         59.01%   58.13%   -0.89%     
================================================
  Files              2225     2151      -74     
  Lines            183562   174994    -8568     
================================================
- Hits             108323   101726    -6597     
+ Misses            65493    64223    -1270     
+ Partials           9746     9045     -701     
Flag Coverage Δ
sei-db 70.41% <ø> (ø)
sei-db-state-db ?

Flags with carried forward coverage won't be shown. Click here to find out more.
see 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@masih
masih enabled auto-merge (squash) August 4, 2026 13:52
@amir-deris
amir-deris self-requested a review August 4, 2026 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants