Repository navigation
Conversation
26 of 42 tasks
…per-build tables AGENTS.md asks for per-game values in the profile, not in code, and host behaviour that depends on a game build to check module_t.build_id. Both hold today: the C and Objective-C sources of dm/host and dm/gfx (tests and third-party code left out) name no game by its title ID in code, and the 32-digit build IDs appear only in hle_fpslock.c and hle_uemalloc.c, the tables keyed by build that seedds#313 wants the profiles to take over. Nothing kept it that way. test_architecture.py fails on a title ID in code (a base game's or an update's, with or without 0x, an integer suffix or quotes; comments that cite a source, like hle_fpslock.c's FPSLocker config path, are left out) and on a quoted build ID outside the two tables. The message says where the value goes instead: the profile, a table row, or the profile's patches.py. Checked: it passes on main and on the open branches that change host code (UE3 support, Arkham Knight, pool peak, launcher schema, sanitizers, dmsh_abi.h, input remap, the adjustable clock); it fails on 0x0100F2C0115B6000ull, an update's 0x...800 and a quoted title ID in hle_os.c, and on a quoted build ID in hle_nvn.c.
seedds
added a commit
that referenced
this pull request
Nov 4, 2026
…nd the build-ID scan reads .inc files test_architecture.py fails on a title ID in the host's code: Switch or Switch 2, a base game, its update or another program of the game, as digits or an integer. Comments and firmware IDs (0100000000000xxx) are left out. The pattern must match every ID the profiles name, so a new family of IDs fails the test instead of passing unseen. docs_patches.host_files() is now the one list of host sources for both checks. It adds .inc, where a build ID was not seen until now. The PR's own build-ID test is left out: test_docs already stops on a host row docs_patches.py cannot classify. Co-authored-by: v0lumehi <[email protected]>
Owner
|
Landed as c7da003, with you as co-author. Thanks.
File size limits stay undecided in #313. |
Know-It-All-Brother
pushed a commit
to Know-It-All-Brother/nxnative
that referenced
this pull request
Nov 9, 2026
…), and the build-ID scan reads .inc files test_architecture.py fails on a title ID in the host's code: Switch or Switch 2, a base game, its update or another program of the game, as digits or an integer. Comments and firmware IDs (0100000000000xxx) are left out. The pattern must match every ID the profiles name, so a new family of IDs fails the test instead of passing unseen. docs_patches.host_files() is now the one list of host sources for both checks. It adds .inc, where a build ID was not seen until now. The PR's own build-ID test is left out: test_docs already stops on a host row docs_patches.py cannot classify. Co-authored-by: v0lumehi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #313 ("Rules that enforce themselves": architecture checks as ordinary tests).
Problem
AGENTS.mdasks for per-game values in the profile, not in code, and for host behaviour that depends on a game build to checkmodule_t.build_id. Today the code follows both rules:dm/hostanddm/gfx(tests and third-party code left out) name no game by its title ID in code;hle_fpslock.candhle_uemalloc.c, the two tables keyed by build.Nothing keeps it that way, though. A quick
if (title_id == 0x0100…)in the core would pass review unnoticed in a 10,000-line file.Change
dm/tools/tests/test_architecture.py:0x, an integer suffix (ull) or quotes, fails. Comments that cite a source are left out, likehle_fpslock.c's path to masagrator's FPSLocker config.hle_fpslock.c/hle_uemalloc.cfails. The 16-digit shader keys innvn_builtin.haren't build IDs and aren't matched.game.tsv, read as aDM_GAME_macro), a table row, or the profile'spatches.py. Your agents run these tests, so they get that hint on their own.When the per-build tables become profile rows (the #313 item),
BUILD_TABLESshrinks with them.Not in this PR: file sizes
The roadmap also names file size limits. I measured before adding one:
nvn_mtl.mshader_split.pybuild_ipa_from_nsp.pyhle_nvn.cA cap on today's sizes would stop your own commits within a day, so I left it out. Two options if you want one:
nvn_mtl.mafter it's split (Split nvn_mtl.m into topic parts (mechanical, identical machine code) #133, mechanical, identical object code), so each part stays reviewable.Your call. Either is one more small test.
Checked
main, and on every open branch that changes host code: UE3 support, Arkham Knight, pool peak, launcher schema, sanitizers,dmsh_abi.h, input remap, the adjustable clock.0x0100F2C0115B6000ull, an update's0x…6800and a quoted title ID added tohle_os.c, and on a quoted build ID added tohle_nvn.c.test_docsOK.