Skip to content

ios/launcher: a Picture section, and the thermal cap as a setting - #357

Open
Xipzer wants to merge 1 commit into
seedds:mainfrom
Xipzer:launcher-picture
Open

Xipzer wants to merge 1 commit into
seedds:mainfrom
Xipzer:launcher-picture

Conversation

@Xipzer

@Xipzer Xipzer commented Oct 27, 2026

Copy link
Copy Markdown
Contributor

A one-section change to the settings screen, prompted by testing the screen on a 13" iPad where Game is the only part that needs scrolling.

The problem

Game carries six rows that have nothing in common except not belonging in Controls or Performance:

Frame rate            how fast the game runs
Render scale          how large it renders
Console mode          what it reports to the game
Upscaling             how the finished frame is scaled
Game language         what it speaks
Frame-rate counter    a read-out

The change

Picture takes the two that are about the finished frame rather than about the game: Render scale and Upscaling. The frame-rate counter moves to Performance, beside the Performance HUD, since both are read-outs rather than settings.

Game         Frame rate, Console mode, Game language
Picture      Render scale, Upscaling
Controls     unchanged
Performance  unchanged, plus Frame-rate counter

Why now

The split matters more as the section grows. With #335 (anisotropic and trilinear filtering) and #345 (upscaling detail and sharpening), Game would hold ten rows, six of which are about how the picture looks. Those four land in Picture instead.

Heading order is the order of SECTIONS, and rows keep their table order within a section, so settings.tsv still decides the layout with no Swift change.

Changes

  • dm/games/settings.py: SECTIONS gains Picture
  • dm/games/settings.tsv: three rows reassigned, the header explains what each section means
  • dm/tools/tests/test_launcher_settings.py: the section assertions, plus one that Picture holds what it should
  • docs/settings.md: a Picture section with the two settings moved under it, the contents list and the intro

test_launcher_settings, test_docs, test_env_switches and test_launcher_storage pass.

No functional change: the same settings, the same defaults, the same variables.

@v0lumehi

Copy link
Copy Markdown
Contributor

I am all for cleaner interfaces. Thanks!

@Xipzer Xipzer changed the title launcher: a Picture section, so Game is about the game again launcher: a Picture section, and the thermal 30 fps cap as a setting Oct 27, 2026
@Xipzer

Xipzer commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Added a second, small commit here since it is the same kind of change: the thermal cap from #220 as a launcher setting.

Halve when hot, in Performance, on by default. Nothing changes unless a player turns it off.

Why it should be the player's choice: on an iPhone 17 Pro Max that had been charging over USB while large apps were installed onto it, Breath of the Wild started already at thermal state 2 and was held at 30 from the first frame. With a phone cooler attached, or for anyone who prefers an uneven 45 to 55 over an even 30, that is the wrong trade, and the only way out was an env.txt edit.

The note is honest about the limit. On the same phone the state read nominal for ten minutes while a third of frames were dropped, and one scene's GPU time went 8.40 → 21.83 ms still nominal (numbers on #314). So the cap catches the hot case, not every slowdown.

test_launcher_settings, test_env_switches, test_docs and test_launcher_storage pass.

@v0lumehi

Copy link
Copy Markdown
Contributor

This is fine for me personally

@v0lumehi

Copy link
Copy Markdown
Contributor

Heads-up: seedds asked in #388 to agree on one settings schema and one store for player choices before the launchers are extended. I posted a proposal there (#388 (comment)): one optional meta column (key=value;…) in settings.tsv, a versioned launcher.json, and one store with one precedence. The Picture section and the thermal cap would fit as ordinary rows, with a group key if the section needs sub-headings. Input welcome in #388.

@Xipzer

Xipzer commented Oct 27, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto the #388 schema (f646545, ab85f03, 6d1e07b). Picture is a plain section string, so it stays schema 1. Basic keeps Render scale, now under Picture; on the Mac, Advanced no longer needs Game, since Upscaling was its only advanced row there. The thermal cap is an ordinary row. test_launcher_settings, test_launcher_storage, test_env_switches and test_docs pass.

@Xipzer

Xipzer commented Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Rebased on current main. Picture now sits between Game and Controls with Render scale (still level=basic) and Upscaling; Frame-rate counter stays platform:ios under Performance next to Halve when hot. Updated the two Swift checks: on the Mac every Game row is basic now, so Advanced lists Picture, Controls and Performance. Launcher tests pass.

@github-actions github-actions Bot added ios The iPhone and iPad app (dm/ios) tools Tools and scripts (dm/tools, scripts) docs Documentation labels Nov 3, 2026
@Xipzer Xipzer changed the title launcher: a Picture section, and the thermal 30 fps cap as a setting ios/launcher: a Picture section, and the thermal cap as a setting Nov 13, 2026
@Xipzer

Xipzer commented Nov 13, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto main (2e6edda) as one commit, retitled to the area/component form. Main added three picture rows under Game since this was written (Game's upscaler, Picture, Picture shape); they move into the Picture section by the rule the table header states, and test_launcher_settings.py expects them there. docs/settings.md#picture is now the section, the Picture setting is #picture-1 (the one link in rendering.md follows). Not updated: docs/frontends.md, docs/launcher.schema.json and dm/games/README.md still name three sections. iOS compile check: 263 files, 0 failed.

Checked on this commit (M4 Max): host build, make -C dm/gfx/tests run (every target passes), the settings / docs / switch-table tool tests. The host tests pass except audio-device checks (t_audio's device stall here, t_audio_device on clean main in the same session).

Game carries eleven unrelated rows: how fast the game runs, how large it
renders, which console mode it reports, how the finished frame is scaled,
fitted and shaped, which language it speaks, how the Mac window opens, and a
frame-rate read-out. The only thing they have in common is that none of them
belonged in Controls or Performance.

Picture takes the rows that are about the finished frame rather than about
the game: Render scale, Upscaling, Game's upscaler, Picture and Picture
shape. Game keeps Frame rate, Dynamic resolution, Console mode, Game language
and the Mac's Display mode. The frame-rate counter moves to Performance next
to the Performance HUD, since both are read-outs rather than settings. The
iOS in-game menu follows the sections, so the counter comes after the
controls there.

The split matters more as the section grows. With the anisotropic and
trilinear filtering of seedds#335 and the upscaling detail and sharpening of seedds#345,
Game would hold fifteen rows, nine of which are about how the picture looks.

The heading order on screen is the order of SECTIONS, and rows keep their
table order inside a section, so settings.tsv still decides the layout on its
own.

In docs/settings.md the Picture section takes the anchor #picture, and the
Picture setting inside it becomes #picture-1.

The thermal cap (seedds#220) holds the frame step at 30 fps while iOS reports a
serious or critical thermal state, and DM_THERMAL_CAP=0 turned it off only
from an env file. It is a trade a player should be able to make: with a phone
cooler, or for a player who would rather have an uneven 45 to 55 than an even
30, it costs more than it saves.

"Halve when hot" in Performance, on by default, so nothing changes for anyone
who does not touch it. Shown only for a game with a frame step, as Hold
frames when late is.

The note says what the thermal state does not catch. On an iPhone 17 Pro Max,
Breath of the Wild 1.9.0 dropped a third of its frames for ten minutes with
the state reading nominal throughout, and one scene's GPU time went from
8.40 ms to 21.83 ms while it still read nominal: iOS lowers the clock well
before it calls the device hot. The same phone, charged over USB while large
apps were installed onto it, started a game already at serious and was held
at 30 from the first frame, which is the case the setting is for.

The tests follow: Render scale is a basic row under Picture, and in the Mac
window's list for Breath of the Wild every Game row is basic, so its Advanced
settings start at Picture.
@Xipzer

Xipzer commented Nov 18, 2026

Copy link
Copy Markdown
Contributor Author

Rebased onto current main. The only conflict was main's new Microphone rows, which stay in Controls; the Picture section, the thermal cap row and the tests are unchanged. Launcher tests, the Swift storage check and the iOS compile check pass.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation ios The iPhone and iPad app (dm/ios) tools Tools and scripts (dm/tools, scripts)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants