Repository navigation
Conversation
|
I am all for cleaner interfaces. Thanks! |
|
Added a second, small commit here since it is the same kind of change: the thermal cap from #220 as a launcher setting. Halve when hot, in Performance, on by default. Nothing changes unless a player turns it off. Why it should be the player's choice: on an iPhone 17 Pro Max that had been charging over USB while large apps were installed onto it, Breath of the Wild started already at thermal state 2 and was held at 30 from the first frame. With a phone cooler attached, or for anyone who prefers an uneven 45 to 55 over an even 30, that is the wrong trade, and the only way out was an The note is honest about the limit. On the same phone the state read nominal for ten minutes while a third of frames were dropped, and one scene's GPU time went 8.40 → 21.83 ms still nominal (numbers on #314). So the cap catches the hot case, not every slowdown.
|
|
This is fine for me personally |
|
Heads-up: seedds asked in #388 to agree on one settings schema and one store for player choices before the launchers are extended. I posted a proposal there (#388 (comment)): one optional |
71ec55e to
a58eac1
Compare
|
Rebased onto the #388 schema (f646545, ab85f03, 6d1e07b). Picture is a plain section string, so it stays schema 1. Basic keeps Render scale, now under Picture; on the Mac, Advanced no longer needs Game, since Upscaling was its only advanced row there. The thermal cap is an ordinary row. |
a58eac1 to
57e5b0a
Compare
|
Rebased on current main. Picture now sits between Game and Controls with Render scale (still |
57e5b0a to
e7e0905
Compare
|
Rebased onto main (2e6edda) as one commit, retitled to the Checked on this commit (M4 Max): host build, |
Game carries eleven unrelated rows: how fast the game runs, how large it renders, which console mode it reports, how the finished frame is scaled, fitted and shaped, which language it speaks, how the Mac window opens, and a frame-rate read-out. The only thing they have in common is that none of them belonged in Controls or Performance. Picture takes the rows that are about the finished frame rather than about the game: Render scale, Upscaling, Game's upscaler, Picture and Picture shape. Game keeps Frame rate, Dynamic resolution, Console mode, Game language and the Mac's Display mode. The frame-rate counter moves to Performance next to the Performance HUD, since both are read-outs rather than settings. The iOS in-game menu follows the sections, so the counter comes after the controls there. The split matters more as the section grows. With the anisotropic and trilinear filtering of seedds#335 and the upscaling detail and sharpening of seedds#345, Game would hold fifteen rows, nine of which are about how the picture looks. The heading order on screen is the order of SECTIONS, and rows keep their table order inside a section, so settings.tsv still decides the layout on its own. In docs/settings.md the Picture section takes the anchor #picture, and the Picture setting inside it becomes #picture-1. The thermal cap (seedds#220) holds the frame step at 30 fps while iOS reports a serious or critical thermal state, and DM_THERMAL_CAP=0 turned it off only from an env file. It is a trade a player should be able to make: with a phone cooler, or for a player who would rather have an uneven 45 to 55 than an even 30, it costs more than it saves. "Halve when hot" in Performance, on by default, so nothing changes for anyone who does not touch it. Shown only for a game with a frame step, as Hold frames when late is. The note says what the thermal state does not catch. On an iPhone 17 Pro Max, Breath of the Wild 1.9.0 dropped a third of its frames for ten minutes with the state reading nominal throughout, and one scene's GPU time went from 8.40 ms to 21.83 ms while it still read nominal: iOS lowers the clock well before it calls the device hot. The same phone, charged over USB while large apps were installed onto it, started a game already at serious and was held at 30 from the first frame, which is the case the setting is for. The tests follow: Render scale is a basic row under Picture, and in the Mac window's list for Breath of the Wild every Game row is basic, so its Advanced settings start at Picture.
|
Rebased onto current main. The only conflict was main's new Microphone rows, which stay in Controls; the Picture section, the thermal cap row and the tests are unchanged. Launcher tests, the Swift storage check and the iOS compile check pass. |
e7e0905 to
297cd3e
Compare
A one-section change to the settings screen, prompted by testing the screen on a 13" iPad where Game is the only part that needs scrolling.
The problem
Game carries six rows that have nothing in common except not belonging in Controls or Performance:
The change
Picture takes the two that are about the finished frame rather than about the game: Render scale and Upscaling. The frame-rate counter moves to Performance, beside the Performance HUD, since both are read-outs rather than settings.
Why now
The split matters more as the section grows. With #335 (anisotropic and trilinear filtering) and #345 (upscaling detail and sharpening), Game would hold ten rows, six of which are about how the picture looks. Those four land in Picture instead.
Heading order is the order of
SECTIONS, and rows keep their table order within a section, sosettings.tsvstill decides the layout with no Swift change.Changes
dm/games/settings.py:SECTIONSgainsPicturedm/games/settings.tsv: three rows reassigned, the header explains what each section meansdm/tools/tests/test_launcher_settings.py: the section assertions, plus one that Picture holds what it shoulddocs/settings.md: a Picture section with the two settings moved under it, the contents list and the introtest_launcher_settings,test_docs,test_env_switchesandtest_launcher_storagepass.No functional change: the same settings, the same defaults, the same variables.