Repository navigation
Add iOS 16.1/17 compatibility and tvOS support for Pokémon Legends: Z-A - #310
widmonstertony wants to merge 16 commits into
Conversation
|
Thanks for putting this up as a draft, and for testing on both an A10X and an M2 iPad. That's real work. Two thoughts, from a contributor's point of view. The scope call is @seedds's. Splitting it up. At +22k / −4.5k lines across 151 files, 157 commits behind
The platform question first. The README currently targets iOS/iPadOS 26+ on A17 Pro / M1 and later, and the host is built around Metal 4 ( If the answer is no, a fork that tracks |
|
Thanks — I agree that the current draft is not reviewable as one PR. I also understand the practical maintenance issue with older hardware. The maintainer cannot reasonably test and maintain a legacy rendering path without access to those devices. I have the A10X and M2 iPads, so I will take responsibility for that path in the public fork instead of asking upstream contributors to carry it. I’ll keep If an individual part is independently useful upstream—for example the tvOS front end or a general bug fix—I’ll rebase only that change onto current Thanks for the clear review guidance. |
|
Thanks for taking it this way, and for owning the older-device path in your fork. That's a really generous answer, and having someone who can actually test on an A10X is worth a lot. Speaking only as a fellow contributor (what lands is @seedds's call): looking through the branch again, two parts might not depend on the older-device question, and I'd personally love to see them as small PRs on current
For the tvOS front end, a short issue first is probably the easiest way to get a scope answer from @seedds before you spend time rebasing it. And since your fork will track |
a465217 to
ad5aea6
Compare
ad5aea6 to
7c5299f
Compare
|
Thank you for the compatibility work and the A10X and M2 iPad testing, and for already offering to maintain the older-device path in your fork. I'm closing this draft in line with that plan. The legacy renderer, older OS baseline and tvOS support introduce substantial additional paths outside nxnative's current support scope. Keeping them working alongside changes to the supported Apple platforms would require ongoing hardware and rendering validation that I don't have the development and testing capacity to take on. For the current project scope, that maintenance burden outweighs the benefit of carrying these paths upstream. Please do continue the work in your fork, where you can maintain and test it on the devices you have. This closed PR will remain available as a record of the implementation and discussion. General bug fixes that also help the currently supported platforms are welcome as small, focused PRs on current |
|
Following up from the launcher side (NX2Apple). Two of the slices @v0lumehi pointed out look worth landing on current On the community side: we keep a short links section in the NX2Apple README, so we are adding a pointer to this fork for people on iOS 16/17 devices who want to keep playing. Whether seedds lists it upstream is his call; the offer on our side stands. Thanks again for taking the review the way you did — the A10X + M2 testing coverage is exactly what this path needs. |
… older devices Its author maintains the legacy Metal renderer path in their own fork (upstream PR seedds/nxnative#310 was closed in favor of that plan), with A10X and M2 iPad testing. Point iOS 16/17 users there.
… and 540p (seedds#302, seedds#307)' (seedds#310) from cr1stian/BananaNative:mtf-resolution into android Reviewed-on: https://git.eden-emu.dev/moceure/BananaNative/pulls/310
Summary
This draft ports the Pokémon Legends: Z-A host to the iOS/iPadOS 16.1 deployment baseline while keeping the newer iOS 17 path, and carries the companion tvOS frontend work developed and tested with the same game profile.
The implementation was developed on the fork's
ios16-pokemon-za-portbranch and is intentionally submitted as a draft because upstreammainhas advanced substantially since the branch point. The validated branch is currently 157 commits behind upstream and has conflicts in the Metal present path, the iOS embedded-image loader, input setup, and packaging scripts. Those conflicts need to be reconciled against the newer upstream architecture before this should be merged.iOS 16/17 work
__TEXTmappings for sideloaded iOS builds, including front-patch layouts.Companion tvOS work
Validation
python3 -m unittest discover -s dm/ios/tests -p 'test_*.py'— 40 passed.python3 -m unittest discover -s dm/tools/tests -p 'test_*.py'— 72 passed.python3 dm/tvos/tests/test_resources.py— all resource validation cases passed.python3 dm/tvos/tests/test_romfs_patch.py— all materialization, rollback, integrity, and concurrency cases passed.python3 scripts/check_ios17_compile.py --all-profiles— 144 arm64 iOS 16.1 unit compilations across 48 profiles, 0 failures.Review note
This is a large compatibility stack rather than a single isolated fix. I opened it as a draft so the validated implementation is visible without force-rebasing it over 157 upstream commits and invalidating the device results. I am happy to split the iOS/tvOS pieces or rework individual subsystems around the current upstream present, loader, and packaging architecture during review.