Repository navigation
Conversation
Add a shoulder-button edit mode with draggable, clamped positions saved separately for each layout. Share the saved centers between drawing and hit testing, release held input when editing, and add harness coverage.
gino8080
force-pushed
the
feat/ios-movable-shoulder-buttons
branch
from
November 18, 2026 08:03
7df8483 to
859dd98
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What and why
L/R and ZL/ZR can be difficult to reach with the fixed touch layout, particularly on a wide screen. Add a gear-menu action to move these four buttons individually, finish editing, or restore their default positions.
The editor stores normalized positions separately for portrait, landscape and tabletop layouts. Drawing and hit testing use the same positions. Buttons stay within the control area, with access to the gear preserved. Entering edit mode releases held input; dragging sends no button presses or touch events to the game. Tap mode and a connected physical controller disable the editor.
The UI harness supplies inert runtime stubs for offline-web touch, reported players, audio route changes and movie activation. The movie stub is needed by the lifecycle calls introduced upstream in
7124b0ad; the harness contains no movie decoder. Production input behavior is unchanged by the rebase.Validation on the current base
Rebased onto
c379a903f47dd6d8cbdc4b2b36e67e7bb8ebc250on 2026-11-18, independently of #2943.testInactiveNativeDivisionCanDriveSeparatedLayout, was reproduced separately with the unchanged production sources and original test from this exact base, using the same link stubs. The suite is not reported as green.git diff --checkpassed.2925d7af, the user moved the shoulder buttons and confirmed they worked during Mario Kart World 1.8.0 play. This updated branch has not replaced that installed build. Other devices and physical tabletop layouts remain untested.Existing failures on main
These checks are still failing on the base, independently of this PR:
t_geometry.m: undeclaredg_mdi_v, reproduced by compiling the target on main.test_shader_toolchain_cache.TargetSelection.test_mesh_compiles_only_requested_targets:dmsh_rewriteis undefined in all three target subcases, reproduced on main.t_audio_deviceunder TSan: data race inmock_aogpd, reproduced on main.t_codec_video.c:111(vt_session_lifecycle). Its tool-test job was cancelled, so the Python failure above was verified locally.Docs
docs/settings.mdcovers editing, persistence, reset scope and when the editor is unavailable. The Mario Kart World note records the earlier device test and its limits.