Skip to content

ios/input: allow dragging and saving shoulder button positions - #2944

Open
gino8080 wants to merge 1 commit into
seedds:mainfrom
gino8080:feat/ios-movable-shoulder-buttons
Open

gino8080 wants to merge 1 commit into
seedds:mainfrom
gino8080:feat/ios-movable-shoulder-buttons

Conversation

@gino8080

@gino8080 gino8080 commented Nov 17, 2026 •

Copy link
Copy Markdown
Contributor

What and why

L/R and ZL/ZR can be difficult to reach with the fixed touch layout, particularly on a wide screen. Add a gear-menu action to move these four buttons individually, finish editing, or restore their default positions.

The editor stores normalized positions separately for portrait, landscape and tabletop layouts. Drawing and hit testing use the same positions. Buttons stay within the control area, with access to the gear preserved. Entering edit mode releases held input; dragging sends no button presses or touch events to the game. Tap mode and a connected physical controller disable the editor.

The UI harness supplies inert runtime stubs for offline-web touch, reported players, audio route changes and movie activation. The movie stub is needed by the lifecycle calls introduced upstream in 7124b0ad; the harness contains no movie decoder. Production input behavior is unchanged by the rebase.

Validation on the current base

Rebased onto c379a903f47dd6d8cbdc4b2b36e67e7bb8ebc250 on 2026-11-18, independently of #2943.

  • Xcode 27.2, iOS simulator: 38 of 39 tests passed, including all three shoulder-editor tests (dragging, silent input, persistence, hit targets, bounds, gear access, orientation separation and reset scope).
  • The one failure, testInactiveNativeDivisionCanDriveSeparatedLayout, was reproduced separately with the unchanged production sources and original test from this exact base, using the same link stubs. The suite is not reported as green.
  • Documentation checks: 6 passed. git diff --check passed.
  • The editor production sources are byte-for-byte unchanged from the previously published PR head; the only additional change is the movie-activation test stub.
  • Earlier physical-device evidence: on an iPhone Duo with iOS 27.2.1, built from 2925d7af, the user moved the shoulder buttons and confirmed they worked during Mario Kart World 1.8.0 play. This updated branch has not replaced that installed build. Other devices and physical tabletop layouts remain untested.
  • No renderer or shader code is changed; the standalone Metal graphics suite and game regression route were not rerun for this UI branch.

Existing failures on main

These checks are still failing on the base, independently of this PR:

  • t_geometry.m: undeclared g_mdi_v, reproduced by compiling the target on main.
  • test_shader_toolchain_cache.TargetSelection.test_mesh_compiles_only_requested_targets: dmsh_rewrite is undefined in all three target subcases, reproduced on main.
  • t_audio_device under TSan: data race in mock_aogpd, reproduced on main.
  • Main's latest CI run also fails the host and ASan jobs at t_codec_video.c:111 (vt_session_lifecycle). Its tool-test job was cancelled, so the Python failure above was verified locally.

Docs

docs/settings.md covers editing, persistence, reset scope and when the editor is unavailable. The Mario Kart World note records the earlier device test and its limits.

  • Player-facing instructions updated.
  • No game files, keys or extracted game data are included.

@github-actions github-actions Bot added ios The iPhone and iPad app (dm/ios) docs Documentation game: 0400C3F00006E000 A game profile labels Nov 17, 2026
Add a shoulder-button edit mode with draggable, clamped positions saved
separately for each layout. Share the saved centers between drawing and
hit testing, release held input when editing, and add harness coverage.
@gino8080
gino8080 force-pushed the feat/ios-movable-shoulder-buttons branch from 7df8483 to 859dd98 Compare November 18, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs Documentation game: 0400C3F00006E000 A game profile ios The iPhone and iPad app (dm/ios)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant