Skip to content

Adicionado tag PROJETO FINALISTICO no documento - #623

Merged
Junior-Shyko merged 1 commit into
developfrom
feature/add_finalistic_project
Oct 14, 2026
Merged

Junior-Shyko merged 1 commit into
developfrom
feature/add_finalistic_project

Conversation

@Junior-Shyko

@Junior-Shyko Junior-Shyko commented Oct 14, 2026 •

Copy link
Copy Markdown
Collaborator

✅ Descrição do propósito desse Pull Request


🧭 Referência a Issue

#621

❓ O que foi feito para atingir isso?


🏃‍♀️ Tipo de mudança

Marque as opções relevantes:

  • Bug fix (correção de bug)
  • Nova feature (mudança não retrocompatível que adiciona funcionalidade)
  • Mudança de breaking (correção ou feature que faria com que a funcionalidade existente não funcionasse como esperado)
  • Documentação (somente mudanças ou atualizações na documentação)

🕵️ Como foi testado?

  • Critério de aceitação
  • Testes de software (TDD, BDD, UNITÁRIO, INTEGRAÇÃO, E2E)

Checklist: ✔️

  • Meu código segue as diretrizes do projeto
  • Eu fiz um code review com minha equipe
  • Eu comentei meu código, especialmente em áreas de difícil entendimento
  • Eu atualizei a documentação correspondente
  • Testes novos e existentes passaram localmente com minhas alterações

Observação:

Summary by CodeRabbit

  • New Features
    • Added the “Projeto Finalístico” placeholder to document configurations. It resolves to the selected budget allocation’s value, with a fallback when no allocation is available.
  • Bug Fixes
    • Document previews now resolve the placeholder consistently with generated documents.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: secultce/efomento/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Essentials
  • Run ID: 302e61d9-4ceb-4b31-bfda-9387ff16cd06
📥 Commits

Reviewing files that changed from the base of the PR and between 2dff3b2 and 092764e.

📒 Files selected for processing: 4
  • app/Services/Documents/DocumentPlaceholderResolver.php
  • resources/js/Components/DocumentViewerDialog.vue
  • resources/js/Schemas/Config/documentConfig.js
  • tests/Feature/Document/DocumentTest.php

Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 5 reviews per hour.

📝 Walkthrough

The document system now supports [finalistic_project]. Backend and frontend resolution use allocation data with fallback values. Shared configuration exposes the placeholder, and feature tests verify the resolved output.

Changes: Finalistic Project Placeholder

Layer / File(s) Summary
Placeholder resolution and configuration
app/Services/Documents/DocumentPlaceholderResolver.php, resources/js/Components/DocumentViewerDialog.vue, resources/js/Schemas/Config/documentConfig.js
The backend and frontend resolve [finalistic_project] from the budget allocation. The shared schema exposes the placeholder.
Placeholder resolution tests
tests/Feature/Document/DocumentTest.php
Document tests verify the placeholder for selected allocations and set the corresponding fixture value.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 09276

The change adds a finalistic project placeholder to documents. No merge-blocking risk was found. The preview fallback can pick a different allocation than the generated document, but this was already true for the adjacent allocation placeholders.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 … Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly describes the main change: adding the PROJETO FINALISTICO placeholder to documents.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 4 functions across 3 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Comment @coderabbitai help to get the list of available commands.

@Junior-Shyko
Junior-Shyko merged commit 392f683 into develop Oct 14, 2026
4 checks passed
@Junior-Shyko
Junior-Shyko deleted the feature/add_finalistic_project branch October 14, 2026 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants