Skip to content

Numero do credor na formalização + Unificação da view e form sections - #619

Open
CaffeineIssues wants to merge 2 commits into
developfrom
feature/unified-view-and-form-sections
Open

CaffeineIssues wants to merge 2 commits into
developfrom
feature/unified-view-and-form-sections

Conversation

@CaffeineIssues

@CaffeineIssues CaffeineIssues commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

✅ Descrição do propósito desse Pull Request

é necessário fazer o merge da branch da mudança dos campos de banco antes de fazer o merge dessa branch

🧭 Referência a Issue

[#614]

❓ O que foi feito para atingir isso?


🏃‍♀️ Tipo de mudança

Marque as opções relevantes:

  • Bug fix (correção de bug)
  • Nova feature (mudança não retrocompatível que adiciona funcionalidade)
  • Mudança de breaking (correção ou feature que faria com que a funcionalidade existente não funcionasse como esperado)
  • Documentação (somente mudanças ou atualizações na documentação)

🕵️ Como foi testado?

  • Critério de aceitação
  • Testes de software (TDD, BDD, UNITÁRIO, INTEGRAÇÃO, E2E)

Checklist: ✔️

  • Meu código segue as diretrizes do projeto
  • Eu fiz um code review com minha equipe
  • Eu comentei meu código, especialmente em áreas de difícil entendimento
  • Eu atualizei a documentação correspondente
  • Testes novos e existentes passaram localmente com minhas alterações

Observação:

Summary by CodeRabbit

  • Improvements
    • Consolidated project details and form section definitions across workflow tabs, preserving their displayed sections and information.
    • Updated project tabs to use the shared section definitions, keeping tab-specific content organized consistently.
  • Documentation
    • Updated guidance for configuring section visibility and form sections to reflect the shared setup.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: secultce/efomento/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0ed77e5c-0db9-40c9-b966-4685a7385995
📥 Commits

Reviewing files that changed from the base of the PR and between 7343e5e and 7f482ef.

📒 Files selected for processing: 30
  • .claude/skills/nova-tab/SKILL.md
  • CLAUDE.md
  • docs/skills/README.md
  • resources/js/Components/DocumentViewerDialog.vue
  • resources/js/Pages/ProjectDetails/Partials/Tabs/BudgetTab.vue
  • resources/js/Pages/ProjectDetails/Partials/Tabs/FormalizationTab.vue
  • resources/js/Pages/ProjectDetails/Partials/Tabs/LegalAnalysisTab.vue
  • resources/js/Pages/ProjectDetails/Partials/Tabs/MonitoringTab.vue
  • resources/js/Pages/ProjectDetails/Partials/Tabs/OpeningTab.vue
  • resources/js/Pages/ProjectDetails/Partials/Tabs/PaymentTab.vue
  • resources/js/Schemas/Budget/formSections.js
  • resources/js/Schemas/Budget/index.js
  • resources/js/Schemas/Budget/viewSections.js
  • resources/js/Schemas/Formalization/formSections.js
  • resources/js/Schemas/Formalization/index.js
  • resources/js/Schemas/Monitoring/formSections.js
  • resources/js/Schemas/Monitoring/index.js
  • resources/js/Schemas/Monitoring/viewSections.js
  • resources/js/Schemas/Opening/formSections.js
  • resources/js/Schemas/Opening/index.js
  • resources/js/Schemas/Opening/viewSections.js
  • resources/js/Schemas/Payment/formSections.js
  • resources/js/Schemas/Payment/index.js
  • resources/js/Schemas/Payment/viewSections.js
  • resources/js/Schemas/formSections.js
  • resources/js/Schemas/getBudgetAllocation.js
  • resources/js/Schemas/getLegalType.js
  • resources/js/Schemas/parseRegistrationFieldValue.js
  • resources/js/Schemas/schemaUtils.js
  • resources/js/Schemas/viewSections.js
💤 Files with no reviewable changes: 17
  • resources/js/Schemas/Budget/index.js
  • resources/js/Schemas/Budget/viewSections.js
  • resources/js/Schemas/Payment/formSections.js
  • resources/js/Schemas/Formalization/index.js
  • resources/js/Schemas/getLegalType.js
  • resources/js/Schemas/Payment/index.js
  • resources/js/Schemas/Formalization/formSections.js
  • resources/js/Schemas/Opening/formSections.js
  • resources/js/Schemas/getBudgetAllocation.js
  • resources/js/Schemas/Budget/formSections.js
  • resources/js/Schemas/Monitoring/index.js
  • resources/js/Schemas/Monitoring/viewSections.js
  • resources/js/Schemas/Opening/index.js
  • resources/js/Schemas/Monitoring/formSections.js
  • resources/js/Schemas/Payment/viewSections.js
  • resources/js/Schemas/parseRegistrationFieldValue.js
  • resources/js/Schemas/Opening/viewSections.js

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

📝 Walkthrough

Workflow view-section definitions and form-section arrays are consolidated in shared schema modules. Project tabs retrieve sections from those modules, and skill documentation describes the shared schema pattern.

Changes: Schema consolidation

Layer / File(s) Summary
Shared schema modules
resources/js/Schemas/viewSections.js, resources/js/Schemas/formSections.js, resources/js/Schemas/schemaUtils.js, resources/js/Schemas/{Budget,Formalization,Monitoring,Opening,Payment}/*, resources/js/Schemas/{getBudgetAllocation.js,getLegalType.js,parseRegistrationFieldValue.js}
Shared modules provide view-section definitions, tab-based filtering, form-section arrays, and schema utility functions. The previous per-stage schema modules and separate helper files are removed.
Tab and documentation updates
resources/js/Pages/ProjectDetails/Partials/Tabs/*Tab.vue, resources/js/Components/DocumentViewerDialog.vue, .claude/skills/nova-tab/SKILL.md, CLAUDE.md, docs/skills/README.md
Project tabs retrieve view sections by tab name and import form-section arrays from shared modules. DocumentViewerDialog.vue imports getBudgetAllocation from schemaUtils. Documentation describes the shared schema structure.

Priority: ➖ Normal

Estimated code review effort: 3 (Moderate) | ~20 minutes

Change: Feature

Merge Risk: ⚪ Minimal · up to 7f482

The schema consolidation preserves the existing tab displays while adding the creditor number. No actionable merge-blocking risk remains after normal checks.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Docstring Coverage Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (10 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed Passed checks: 4 passed
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly identifies the two main changes: adding the creditor number to formalization and unifying the view and form sections.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 7 functions across 3 files. (10 skipped: 10 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches: 💡 1
📝 Generate docstrings: 💡
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

ESLint install timed out. The project may have too many dependencies for the sandbox.

Comment @coderabbitai help to get the list of available commands.

@CaffeineIssues CaffeineIssues self-assigned this Oct 14, 2026
tabs: ['monitoring'],
title: 'Dados do agente',
fields: [
{ label: 'CPF / CNPJ', key: 'agent.latest_snapshot.cpf_cnpj' },

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

aqui esta sem funcao de mascara, vai confundir o usuario. (acho que já estava)

{
key: 'address',
tabs: ['opening', 'formalization', 'legalAnalysis'],
title: 'Endereço',

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Por favor, tentar criar um unica funcao para essa key e a key agentProjectWithAddress, acho que pode ter sido fruto de como estava antes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants