Conversation
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 50.74% 52.69% +1.94%
==========================================
Files 53 58 +5
Lines 6010 6156 +146
Branches 1796 1805 +9
==========================================
+ Hits 3050 3244 +194
+ Misses 2958 2910 -48
Partials 2 2
🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LearningSuite sync could miss secondary videos, stall behind provider-specific dialogs, or report success after incomplete scans. I now read all loaded HLS players through their public metadata API, retain available subtitles, and report incomplete extraction or downloads as failures.
I made dialog handling optional and independent of a particular welcome screen. Registration does not wait for a dialog: handlers react to visible native/ARIA dialogs and common modal containers with explicit dismissal controls. I cover late controls, stacked overlays, localized labels, and ineffective close icons while excluding form submissions and required decisions. Unsupported overlays retain the normal navigation timeout.
I removed the requirement for a particular media URL path, preserve existing archive IDs, and derive stable fallback IDs without expiring access signatures. Subtitle extraction supports blob, inline VTT, and HTTP(S) tracks. Caption Markdown follows the CLI/configured language, then the provider's default track or track order; all available tracks are retained.
I added
--refresh-mediato inspect previously downloaded lessons while reusing video files. Additional videos receive distinct filenames, failed downloads keep their lesson in an error state, and failed navigation cleans up media listeners.For Apple Speech's zero-duration-word error, I retry once with two seconds of silence in a temporary audio copy. I preserve the original file, record the padding in transcript metadata, exclude it from media duration, and retain the actual Cuttledoc error when progress output precedes it.
Validation:
pnpm check: formatting, lint, type checking, 697 unit tests, and build passed.pnpm test:integration --coverage: 28 tests passed, including Chromium fixtures, real HLS downloads, and ffmpeg padding/cleanup on success and failure. I added integration coverage uploads alongside unit coverage in CI.I preserved the automatic transcription behavior already on
mainand formatted the generated 1.6.0 changelog so the repository-wide format check passes.