Repository navigation
fix(node): settle the expand promise when its thread cannot start - #64
Merged
Merged
Conversation
expand moved its deferred into the thread's closure, so a failed spawn dropped it unsettled. JsDeferred has no Drop, and its thread-safe function stays referenced, so the promise leaked and kept Node's event loop alive; the caller got a thrown error and a promise that never settles. Hand the deferred over a channel once the thread exists, as the diff queue does, and reject it with the spawn error otherwise.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If
expandcouldn't start its thread, its promise never settled and kept Node's event loop alive, because the unsettled deferred was dropped inside the failed spawn's closure. The deferred is now handed over a channel once the thread exists, asdiff's queue already does, and rejected with the spawn error otherwise.