Repository navigation
test(ui-server): isolate maintenance fixtures and gate Pi scope progress - #2665
Merged
Merged
Conversation
Owner
Author
|
Final draft handoff for head
The coordinator owns ready-candidate confirmation and merge. The historical fchown diagnostic remains explicitly unattributed; no production unknown-version or admission policy is changed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2651
Closes #2655
Closes #2656
What changed
In-memory sync and app fixtures execute the original tests in fresh processes with unique private default maintenance ledgers. A separate acknowledged process holds the entire foreign 256 MiB ledger throughout each regression. Pi fixture calls three/four wait for completed observation and accepted Continue, with deliberate buffered delivery and a separate four-call Stop-only control.
Why this shape
Reuse the existing test-owned user/mount namespace launcher: literal
dbPath: ":memory:", private temporary mirror, real workers, exact commit comparisons and production admission remain intact. The fixture checks distinct ledger inodes, unchanged same-domain refusal, live owner/reservation state, stream/process settlement and empty ledgers before deletion. Pi uses fixture-only checkpoint/Continue acknowledgements through its test pipe; the real adapter, journal and native freezer still execute.Proof
Final tested head:
fdd37e926e73332806c496ea4ada851224fc0c34.Merged/tested base:
aeaaf7794b6be41fde4e01bef78ce3f1a5828ac6(#2397); initial base:4d3c58db11eb7c9507d7e81bdd55cb56adc64b1b.All exit 0. Final-head import-graph feedback executes the complete three-file combination: 54 pass / 0 fail, including all four original scope cases plus the overshoot control. Existing maintenance-budget controls pass 10/10 in an owned ledger namespace, including same-domain cross-process refusal, simultaneous admission, live-child retention and unknown-namespace ownership. An acknowledged holder's SIGTERM control exits 0 with its reservation released and joined. No exclusive Btrfs/loop fixture is used; no native lock wraps ordinary tests, mutations or preflight.
Final-head contention batch: 10/10 runs passed, each executing all four named cases (40/40 case passes) on two CPUs plus two bounded busy loops. Every run retained live foreign maintenance reservations and the exact Pi two-call grant assertions. Both pressure groups were terminated and joined; a final /proc check found no live members.
#2651 — in-memory sync isolation
worker_state_busyfrom real sync transport admission.TEMP_MIRROR_FILE_TRANSPORT_WORKSand exact local/remote commit assertions pass while the foreign holder remains live and reserved. Full 14-case sync file passes in final preflight.#2655 — version-pin and ambient-wrapper isolation
syncedassertion receives maintenance-busy SSE and exits 1.fchown EPERMwarning's original owner/order remains unattributed.#2656 — Pi progress gate and overshoot control
SCOPE_ADAPTER_PAUSES_WITH_EXACT_FINITE_CEILINGassertion sees count 4, overshoot 2, nonewCap, and the exact exhausted-ceiling Stop-only reason; exit 1.Checklist
Anything left open
The coordinator owns ready-candidate hosted confirmation and merge. This PR remains draft. Historical fchown warning provenance is not claimed as diagnosed; the controlled admission failure and fixture isolation are the demonstrated repair.