Repository navigation
test(ui-server): await scope observation before continuation - #2437
Merged
Merged
Conversation
schlessera
marked this pull request as ready for review
October 19, 2026 09:24
schlessera
marked this pull request as draft
October 19, 2026 15:22
…6-scope-observation-r1-k8v3
schlessera
marked this pull request as ready for review
October 19, 2026 15:51
This was referenced Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #2436
What changed
The real-worker scope-cap test now waits for journal observation completion before submitting its first continuation. A controlled Pi capture-commit gate preserves the published finite offer while observation remains held, asserts the intended refusal without consuming the grant or resuming the worker, then releases the gate and awaits journal idle. The test checks acceptance of the first grant and its duplicate before waiting for the second pause.
Why this shape
The original failed confirmation 39225826747, attempt 1, unit shard 2 job 117972100537 retained two first-grant refusals while the finite four-call offer remained published. No accepted grant or second pause followed. This establishes a missing acceptance transition; which historical observation/checking hold was active remains unknown. The existing journal idle boundary synchronizes the fixture without changing production guards or adding a production seam. Passing main run 39224911471 did not select this case and is not a matching-case control.
Proof
Current candidate head
9d1ef15a9c7ae96affa1d4374da23561506f5f35, treea678cbdec549c35130a47a9147de2982ae25e9ad, targets live maine16b8407f81da4071a3a1bf1cc04299acb1a2522. The normal refresh merge has parents617fbe01017646ed31fe3e775c7eba1f20659e63ande16b8407f81da4071a3a1bf1cc04299acb1a2522. Only the two already merged ui-kit test corrections arrived from main. The scope-cap contribution remains byte-identical to its independently reviewed implementation: SHA-2567c84a561daa3e184d91affd6bb153072ac439253e7cc228d49b86492859087e3.Local Bun is 1.4.3 with a frozen private copyfile installation; hosted CI pins 1.4.2. Ordinary offline namespaces preserve the real worker, original temporary filesystem, private output/ledger ownership, route guards and zero capabilities. This is not native storage or complete hosted qualification.
The following focused behavioral receipts retain their actual original source identity, head
617fbe01017646ed31fe3e775c7eba1f20659e63/ treee15a051379c05d1eba022309d7f35ccef2963333/ base09eb1f78e99555110f4ef1c8b78e23d188ec77e5. They were not replayed or relabeled as new combined-tree mutation evidence. Independent source review found no findings.SCOPE_ADAPTER_FIRST_GRANT_AND_DUPLICATE_ACCEPTEDreceives tworefusedstates after the held-window security assertions pass.Fresh actual preflight after the refresh ran once and exited 0 in 65.99 seconds: 53 fast tests / 1,371 assertions across three files, then four scope-cap feedback tests / 41 assertions. Strict root types ran once and passed in 84.74 seconds. No install, build, browser, storage prover or repeated focused mutation was run. Source, installed dependencies and lock inputs remained unchanged. Memory and temp-space admission were measured separately; both retained their original guards, and all owned processes drained with empty ledgers and an available output lease.
The actual default plan selects three ui-server fast invariant files (auth, HTTP principal boundaries and session cookies), followed by import-graph feedback. Complete selected hosted unit, browser, layout, captures, endurance and runtime proof remains required; packaging is unselected.
Checklist
docs/reflect the change, or nothing documented moved.Anything left open
Current confirmation 39281051408, attempt 1, passed every selected job and the independently validating aggregate. All 16 executed job checkout logs resolve to
79f251659e84f02f2247543aeb7e5e579bd270b6, treea678cbdec549c35130a47a9147de2982ae25e9ad, parentse16b8407f81da4071a3a1bf1cc04299acb1a2522and9d1ef15a9c7ae96affa1d4374da23561506f5f35. All 13 final resource receipts agree. Metadata requested the same head/base with confirmation cadence and no retained domains. Aggregate job 118160340561 passed; packaging was intentionally unselected. Historical fixture receipts retain their original identities. This controlled boundary regression does not identify the particular historical hold or qualify PR #2435. No production guard was relaxed. Merge verification remains the coordinator's next action.Previous hosted confirmation
Run 39229782185 tested the original scope-only candidate
617fbe01against09eb1f78and failed browser shard 2 on the separate #1229 combined module-settings timeout; the aggregate rejected that failure. Other selected jobs passed. That failed run is preserved without retry. Main now contains the reviewed module-settings and overlay corrections from PR #2442; the refreshed scope candidate requires a new confirmation on the exact current head/base. Intermittent #2413 and #2446 remain separately tracked and any selected recurrence still blocks merge.Main assessment and next confirmation
Automatic main push run 39277088142 completed with failure: unit shard 3 job 118144658940 failed
mounted jobs settings reject invalid boards before writes and save an intentional empty selectionat jobs-board-selection-http.test.ts:33, receiving HTTP 500 withstartup directory membership changed while copying. This is the separately tracked #2413 symptom; its cause remains unknown. Runtime-host and aggregate jobs were cancelled, so that main run is not green. The current candidate's complete selected proof passed, including the same test in unit shard 2 job 118155691191. This passing control does not establish a repair for #2413. No failed main job was rerun or waived.