Repository navigation
test(ui-react): await accepted queue rendering in continuity checks - #2188
Merged
Merged
Conversation
…5-continuity-windows-c1855a
schlessera
marked this pull request as ready for review
October 16, 2026 17:34
schlessera
marked this pull request as draft
October 16, 2026 17:34
…5-continuity-windows-c1855a
schlessera
marked this pull request as ready for review
October 16, 2026 17:43
This was referenced Oct 16, 2026
schlessera
marked this pull request as draft
October 17, 2026 10:51
…5-continuity-windows-c1855a
…5-continuity-windows-c1855a
This was referenced Oct 17, 2026
schlessera
marked this pull request as ready for review
October 17, 2026 21:15
schlessera
marked this pull request as draft
October 17, 2026 21:37
This was referenced Oct 17, 2026
schlessera
marked this pull request as ready for review
October 18, 2026 00:17
schlessera
marked this pull request as draft
October 18, 2026 00:35
schlessera
marked this pull request as ready for review
October 18, 2026 00:53
schlessera
marked this pull request as draft
October 18, 2026 01:12
…windows-c1855a # Conflicts: # docs/process/test-waits.md
schlessera
marked this pull request as ready for review
October 22, 2026 11:12
This was referenced Oct 22, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1855
What changed
The two ten-cycle continuity cases await native per-payload queue receipt minima and finite rendering for already-accepted queues, replacing twenty 500 ms observation windows. All 15 cases, both viewport paths, ten cycles per viewport, original identity/layout/focus/draft/upload/no-send assertions and the other 87 observation windows remain. Production behavior and the machine contract are unchanged.
This refresh merges main
736a3445e82aee509e10f3c8d00b95fc77749202into the preserved slice atb7afb3c288f7ffc5938e80a670f9c45c1f4d593e. It inherits #2394's fixture precondition and #2458's shared runtime-build hooks from main. The initialdocs/process/test-waits.mdconflict retains both the queue explanation and main's private-conformance-clock section; later citation overlaps are resolved against the combined source. The client fixture and historical JSON evidence remain byte-identical to preserved headfc086b3498ed55a5423a41cab4e31eddd6dccd05. The diff against merged main remains the same four-file slice; no separately owned fixture or build change is introduced by this PR.Why this shape
The fixture limits replacement to the synchronous pending-queue branch: an already-accepted request, a held running turn, and no started/dropped follow-up, transcript adoption or history refresh. Receipt minima tolerate legitimate identical reports; existing finite rendering precedes the original identity assertions. The lower pending-stack test owns synchronous store application, while real Chromium owns delivery, rendering and continuity. The source-bound study retains the original mutations, delayed/premature/duplicate controls and measurement limits.
Proof
Current refresh head:
b7afb3c288f7ffc5938e80a670f9c45c1f4d593e; merged base:736a3445e82aee509e10f3c8d00b95fc77749202.bun run typecheck(tsc --noEmit) andbun run lintpass.queueMicrotaskfailsthe host's report is the pending stack, and none of it is in the chatat its unchanged immediate text assertion (expected the two queued texts, received[]; 0 pass / 1 fail / 3 assertions). Restoring the source passes all 20 lower tests / 86 assertions.cycle 1, reconnected: no pending pill was removed during recovery(expected 0, received 1; 0 pass / 1 fail / 67 assertions). Both production mutations are restored byte-for-byte.bun run check:pr --base origin/mainpasses all contribution gates, 54 fast tests / 181 assertions, and all 15 real-Chromium continuity cases / 1,876 assertions, with no skips. Both ten-drop paths and IME cases pass. Exactly 87 observation calls and 87 retained frame calls remain (44,586.047 ms in the original native observations). Whole preflight: 529.38 seconds; native runner: 417.96 seconds. Main's new invocation harness separately reports an 80.42-second package build. These are qualification costs on the stated tree, not a new matched saving.BRAIN_REQUIRE_CHROME=1. The repositoryscripts/test-offline.shlauncher provides fresh user/network namespaces, loopback plus a dummy interface, empty IPv4/IPv6 main route tables and all five capability sets zero. The preload and browser-origin guards remain enabled. Browser/unit/mutation/preflight commands run directly without the exclusive native Btrfs/loop fixture lock.The historical matched queue sections measured 10.973 to 1.270 seconds (9.703 seconds observed saving). Setup/shared-host variation and the original strict/minimum-predicate distinction remain in the study; this refresh makes no new speedup claim.
Ready run 39084453976 remains failed at historical head
fc086b3498ed55a5423a41cab4e31eddd6dccd05: browser (2) and aggregate failed while the target continuity file passed 15 cases / 1,876 assertions. Earlier failed and cancelled runs retain their actual identities in the issue history. The 2026-10-22 maintainer ruling removes the remaining blocker edge; it does not relabel those runs as successful proof.Checklist
Anything left open
This accepted-queue slice uses Refs and leaves #1855 open for the remaining 87 caller-specific observation windows and original inventory, horizon/equivalent-completion, margin and execution-tier criteria. Retained durations are not established minima. The scope excludes #2394's separately owned continuity/parallel-session fixture preconditions.
This invocation stops at an updated draft with passing focused preflight and current-head draft gates. The coordinator owns ready transition, complete selected candidate confirmation, actual checkout/aggregate verification and merge. Those steps remain outstanding; cheap draft gates are not complete hosted proof. A proposed finite split of the remaining issue criteria will be handed to the coordinator separately, without filing issues here.