Repository navigation
chore(ci): separate native hosted runtime proof - #2163
Merged
Merged
Conversation
Keep all five runtime phases, deadlines and offline prerequisites. Preserve the shared-process Chrome pair and require both selected jobs in the executable aggregate. Real shared-lease controls reject unsafe same-checkout concurrency. Red first: new host selection assertion received undefined. Removing runtime_host from aggregate inventory made emitted skipped-job test return 0 instead of 1. Restored passes. Prefix-command mutation allowed runtime_host to impersonate runtime; exact-category workflow assertion failed and passes restored.
schlessera
marked this pull request as ready for review
October 16, 2026 15:04
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #2128
What changed
Native hosted admission now runs as its own selected
runtime_hostjob. The existingruntimejob retains the three offline Claude probes and the shared-process Chrome/child-cleanup command. Both selections derive from the same runtime requirement; the aggregate rejects a missing, skipped, failed or cancelled selected job. Localcheck:pr --full/--allstill execute all five original commands.Why this shape
The two long phases share the same exclusive workspace-output lease when launched in one checkout. The native container binds that same lease; Chrome fixtures rebuild while holding it. Real host/container contention and nested-build controls pass without relaxing ownership. Separate runners preserve the existing phase assertions, cell order, loop1790 ownership, namespace/capability setup, quota invariants, deadlines and artifacts. The exact Chrome pair still runs in one process with
--shard=1/1.The declared primary sequencing condition is met: prerequisite implementations #2121/#2144 (
f375261f), #2122/#2143 (3031e31a) and #1836/#2062 are merged. The first two issues remain open for their measurement criteria. This does not claim qualified unit parallelism, completed prerequisite criteria or a runtime critical-path improvement.Proof
Production source:
e7fea8b1ecb4a9f89f8651eca37e0bca797c20ad, based on72cc84f3f793ad52e25198e046461f81927aac7a.PROOF_JOBSthen made the emitted skipped-job aggregate return zero instead of the expected failure; restored tests pass.runtime_hostto masquerade as theruntimecommand. The workflow test failed its intended refusal assertion, then passed restored. The diff/file was searched for other category inventories and updated consistently.runtime_host: false. A moved workflow-install citation was corrected; all 44 citation tests / 113 assertions pass. Strict typecheck passes.bun run check:pr --base origin/mainpasses: 916 fast tests / 6,131 assertions plus 130 import-graph feedback tests / 1,222 assertions, lint/leakage and contribution gates. Current hosted measurements remain pending. No cancelled, queued or failed run is counted as passing proof.Historical successful main 38903809808, actual source
626a03af, recorded serial runtime 702.725 seconds: probes 13.522 / 9.719 / 4.571 seconds, hosted admission 424.345 seconds and shared-process cleanup 250.566 seconds. Its resource artifact reports four CPUs, 2.540 GB sampled VM usage of 16.766 GB and 884.56 active CPU-seconds. This different-source observation is historical, not a controlled current-source speedup.No changeset: repository CI/tooling and decision documentation only; no shipped package, dependency or public machine contract changes.
Checklist
Anything left open
Approved runtime-only experiment 38920698136 is dispatched from workflow commit
fb50569d8941b9dc4e9ca1eb26c2b4f2396e200c; both jobs pin the full production source SHA above. Native-host job117039562506and runtime job117039562734are queued, so no executed checkout or passing measurement exists yet. The temporary experiment branch is outside this PR.The runtime-only two-job experiment must reconcile both actual source checkouts, all five phase results, resource receipts and full job/setup wall time against the longest single phase plus 90 seconds. One confirmation and one actual-main run must show every original phase. This implementation uses
Refs #2128while those measurement and delivery criteria remain open. Retained focused passing proof and scoped conflict checks follow the maintainer's explicit instruction to avoid a full refresh solely for base advancement; no full current-candidate hosted pass is claimed.Current-base assessment: prospective merge onto inspected main
cf70a33f2e9d4edee54180c95f8328907ee988c0is conflict-free (tree5f75530d5f191f6615f78736a7c67577b0cdbf84). Incoming changes do not modify this PR’s CI, planner, guard or test files. Its shared Claude decision document has disjoint SDK/lockfile citation updates, preserved by the merge. Historical local receipts remain attributed to their actual production source; this source inspection is not a new combined-tree test execution.Actual merge reconciliation
Merged as
80e028d84b7686d6cf864d8166029b1142de8756, parentcf70a33f2e9d4edee54180c95f8328907ee988c0, tree5f75530d5f191f6615f78736a7c67577b0cdbf84, matching the inspected prospective merge and verified as an ancestor of main. Actual-squash focused checks pass 139 tests / 1,184 assertions; strict types pass. Automatic main CI and the preserved two-job experiment remain queued. Only redundant queued premerge CI38920939566was cancelled after saving its metadata. Issue #2128 remains open with its measurement/event-phase criteria; both PR and issue retain release milestone 0.44.0.