0.109.2 - Storybook test runner: wait for the reduced-motion change event before rendering a story - #125
Merged
Conversation
…vent before rendering a story Playwright's media emulation flips `matchMedia(...).matches` at once, but the query's `change` event only arrives a few frames later. Framer Motion caches the preference from that event, so a story that mounted in between saw reduced motion in CSS and in its play() guard while still animating in JavaScript. This made `Layout/Dashboard Layout › RespectsPrefersReducedMotion` flaky (the wordmark was part-way through its fade when the assertion ran). `preVisit` now waits for the `change` event whenever the emulation actually changes, before the story renders. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01DYdpBAxKCUbEwPapiBDEmi
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Playwright's media emulation flips
matchMedia(...).matchesat once, but thequery's
changeevent only arrives a few frames later. Framer Motion cachesthe preference from that event, so a story that mounted in between saw reduced
motion in CSS and in its play() guard while still animating in JavaScript.
This made
Layout/Dashboard Layout › RespectsPrefersReducedMotionflaky(the wordmark was part-way through its fade when the assertion ran).
preVisitnow waits for thechangeevent whenever the emulation actuallychanges, before the story renders.
Co-Authored-By: Claude Opus 5.5 [email protected]
Claude-Session: https://claude.ai/code/session_01DYdpBAxKCUbEwPapiBDEmi