Show dynamic client registration filter only when relevant - #240
Merged
Merged
Conversation
…n it can never match The filter is now offered only while dynamically registered apps are listed, or (for admins) while the allow_dynamic_client_registration server setting is on. With registration disabled and no such apps it could only ever show an empty list. Co-Authored-By: Claude Opus 5.5 <[email protected]> Claude-Session: https://claude.ai/code/session_01A8Vv7kg345b39kDHsPM1qw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Conditionally display the "Dynamic registration" filter on the apps page based on whether dynamic client registration is enabled on the deployment and whether there are any dynamically registered apps to display.
Changes
isDynamicClientRegistrationEnabledsetting (only for admins, since non-admins cannot see dynamically registered clients)dynamic_client_registration_enabledprop to track the server settingImplementation Details
getUserAccessLevelForOwnership()restricts dynamic client registration visibility to global admins onlyfalsewithout making the async callfalse, ensuring the filter is still offered when dynamically registered apps exist (graceful degradation)https://claude.ai/code/session_01A8Vv7kg345b39kDHsPM1qw