Stabilize Windows UIA validation - #621
Merged
Merged
Conversation
Co-authored-by: Copilot App <[email protected]> Signed-off-by: Colin Neilens <[email protected]>
Co-authored-by: Copilot App <[email protected]> Signed-off-by: Colin Neilens <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Makes the Windows native UIA qualification gate reliable on shared interactive
desktops and long worktree paths, so successful product behavior is no longer
reported as failed validation or blocked cleanup.
Changes
when shared-desktop
SendInputdoes not reach the verified menu, combo,button, edit, or navigation target
evidence instead of silently treating message delivery as physical input
pre-run process baseline
-ShellValidationRootso isolated UIA fixtures can use apath-budget-safe owned root
provider cleanup, and short-root isolation
Test plan
RED: pwsh -NoProfile -File Tools\windows\uia-live-gate.ps1 -Shell graphcode-windows\zig-out\bin\graphcode-windows.exe -Zmx .graphcode-tools\providers\zmx\zig-out\bin\zmx.exe -> canvas edge Edit Edge popup remained open after the measured click with hilite=false
GREEN: pwsh -NoProfile -File Tools\windows\validate.ps1 -Task windows-shell -ShellPart integration -SkipTrayLive -ShellValidationRoot C:\v5 -SwiftExecutable $env:GRAPHCODE_SWIFT633 -> exit 0; native UIA gate completed and provider cleanup terminated 8 owned fixture processes
REGRESSION: pwsh -NoProfile -File Tools\windows\Tests\WindowsShell.Tests.ps1 -ZigExecutable $env:GRAPHCODE_ZIG0152 -> 52/52 sections passed, App 736/736 passed, Worktree process 21/21 passed
Checklist
git commit -s) per the DCOmake test)make check)make testandmake checkare macOS entry points and were not run on thisWindows host; the Windows-specific commands above are the applicable repository
validation.