Skip to content

Make Delete the default button in the loop delete dialog - #613

Open
scgopi wants to merge 1 commit into
mainfrom
fix/delete-dialog-default-action
Open

scgopi wants to merge 1 commit into
mainfrom
fix/delete-dialog-default-action

Conversation

@scgopi

@scgopi scgopi commented Oct 3, 2026

Copy link
Copy Markdown
Owner

⌘W raises the delete-loop confirmation, but Cancel held the default, so confirming meant reaching for the mouse. Delete now carries .keyboardShortcut(.defaultAction), so Return deletes and Escape still cancels.

RED: n/a -> UI keyboard default in a SwiftUI confirmationDialog has no unit-testable surface
GREEN: xcodebuild -scheme graphcode build -> exit=0, ** BUILD SUCCEEDED **
REGRESSION: swift format lint --strict + swiftlint on AppView.swift -> clean

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant