Nod: auto-accept edits by default, and offer Copilot's current models - #611
Merged
Merged
Conversation
- Edits in a loop's worktree are auto-accepted by default on both engines (NodSettings and the runtime's defaults), and stay reviewable until the turn ends. Settings that already store a choice keep it. - The Copilot catalog tracks copilot help config at 1.0.89 (29 models plus Auto) instead of 5; each tier's default is unchanged. - graphcode-nod --list-models asks the Copilot SDK which models the account may use; the app runs it at launch, caches the answer, and merges anything the built-in list lacks. The SDK answers only "Auto" for some accounts today, which is why the built-in list stays the base. Co-Authored-By: Claude Opus 5.5 <[email protected]> Signed-off-by: scgopi <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NodSettings.editsInWorktreeand the runtime'sdefaultSettingsdefault toautoon both engines; hunks stay reviewable until the turn ends. Settings files that already store a choice keep itcopilot help configat 1.0.89: 29 models plus Auto, instead of 5. Each tier's default is unchanged (Opus 5.5 / GPT-6 Sol / GPT-5.6 Luna)graphcode-nod --list-modelslistModels()for the signed-in account, drops policy-disabled models, prints JSON--list-modelsin the background, and merges models the built-in list lacksThe SDK's
listModels()answers onlyauto(twice) for this account, even after a session starts, whileclaude-sonnet-5,gpt-6-solandgpt-5-miniall answer when requested. That's why the built-in list stays the base and the SDK's answer only adds to it.Evidence
RED: NodModelCatalogTests.copilotOffersTheCLIsModelsAndKeepsItsDefaults on origin/main -> fails, the catalog has 5 Copilot models and no auto; bun test listModels.test.ts on main -> fails, CopilotEngine has no listModels
GREEN: xcodebuild test -only-testing NodModelCatalogTests + NodSettingsTests -> exit 0, 16 tests passed; bun test -> 128 pass, 0 fail; tsc --noEmit -> exit 0
REGRESSION: full xcodebuild test -> 2217 tests, only MessageDeliveryTests.aSessionWhoseTaskEndedIsNeverTypedInto fails, identically on main on this Mac; cli and daemon builds exit 0; make check 0 errors; swift-portable exit 0