Skip to content

chore(deps): update module sigs.k8s.io/controller-runtime to v0.23.3 - autoclosed - #40

Closed
scality-renovate[bot] wants to merge 1 commit into
mainfrom
renovate/sigs.k8s.io-controller-runtime-0.x
Closed

chore(deps): update module sigs.k8s.io/controller-runtime to v0.23.3 - autoclosed#40
scality-renovate[bot] wants to merge 1 commit into
mainfrom
renovate/sigs.k8s.io-controller-runtime-0.x

Conversation

@scality-renovate

@scality-renovate scality-renovate Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
sigs.k8s.io/controller-runtime v0.22.3 → v0.23.3 age confidence

Release Notes

kubernetes-sigs/controller-runtime (sigs.k8s.io/controller-runtime)

v0.23.3

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.23.2...v0.23.3

v0.23.2

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.23.1...v0.23.2

v0.23.1

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.23.0...v0.23.1

v0.23.0

Compare Source

🔆 Highlights

⚠️ Breaking changes

  • Dependencies: Update to k8s.io/* v1.35 by @​alvaroaleman @​dongjiang1989 @​kannon92 (#​3316, #​3349, #​3386, #​3391, #​3401)
  • Client: Add subresource Apply support by @​alvaroaleman in #​3321
  • Events: Migration to the new events API by @​clebs in #​3262
    • Using the new GetEventRecorderFor requires updating your rbac for events to use the events.k8s.io apiGroup rather than the `` (core) apiGroup
  • Fakeclient: Set ResourceVersion for SSA Create by @​alvaroaleman in #​3311
  • Webhooks: Generic Validator and Defaulter by @​alvaroaleman in #​3360
    • Existing code of the form builder.WebhookManagedBy(mgr).For(&corev1.Deployment{}) has to be changed to builder.WebhookManagedBy(mgr, &appsv1.Deployment{})
    • Existing webhook implementations have to be changed to take the concrete object rather than runtime.Object, for example from ValidateCreate(ctx context.Context, obj runtime.Object) (admission.Warnings, error) to ValidateCreate(ctx context.Context, obj *appsv1.Deployment) (admission.Warnings, error)

✨ Features

🐛 Bugfixes

🌱 Other

📖 Documentation

Dependencies

Added
  • github.com/Masterminds/semver/v3: v3.4.0
  • github.com/gkampitakis/ciinfo: v0.3.2
  • github.com/gkampitakis/go-diff: v1.3.2
  • github.com/gkampitakis/go-snaps: v0.5.15
  • github.com/goccy/go-yaml: v1.18.0
  • github.com/joshdk/go-junit: v1.0.0
  • github.com/maruel/natural: v1.1.1
  • github.com/mfridman/tparse: v0.18.0
  • github.com/tidwall/gjson: v1.18.0
  • github.com/tidwall/match: v1.1.1
  • github.com/tidwall/pretty: v1.2.1
  • github.com/tidwall/sjson: v1.2.5
  • go.uber.org/automaxprocs: v1.6.0
  • golang.org/x/tools/go/expect: v0.1.0-deprecated
  • golang.org/x/tools/go/packages/packagestest: v0.1.1-deprecated
Changed
  • github.com/go-logr/logr: v1.4.2 → v1.4.3
  • github.com/google/pprof: d1b30fe → 27863c8
  • github.com/onsi/ginkgo/v2: v2.22.0 → v2.27.2
  • github.com/onsi/gomega: v1.36.1 → v1.38.2
  • github.com/prometheus/client_golang: v1.22.0 → v1.23.2
  • github.com/prometheus/client_model: v0.6.1 → v0.6.2
  • github.com/prometheus/common: v0.62.0 → v0.66.1
  • github.com/prometheus/procfs: v0.15.1 → v0.16.1
  • github.com/rogpeppe/go-internal: v1.13.1 → v1.14.1
  • github.com/spf13/cobra: v1.9.1 → v1.10.0
  • github.com/spf13/pflag: v1.0.6 → v1.0.9
  • github.com/stretchr/testify: v1.10.0 → v1.11.1
  • go.etcd.io/bbolt: v1.4.2 → v1.4.3
  • go.etcd.io/etcd/api/v3: v3.6.4 → v3.6.5
  • go.etcd.io/etcd/client/pkg/v3: v3.6.4 → v3.6.5
  • go.etcd.io/etcd/client/v3: v3.6.4 → v3.6.5
  • go.etcd.io/etcd/pkg/v3: v3.6.4 → v3.6.5
  • go.etcd.io/etcd/server/v3: v3.6.4 → v3.6.5
  • go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp: v0.58.0 → v0.61.0
  • go.opentelemetry.io/otel/metric: v1.35.0 → v1.36.0
  • go.opentelemetry.io/otel/sdk/metric: v1.34.0 → v1.36.0
  • go.opentelemetry.io/otel/sdk: v1.34.0 → v1.36.0
  • go.opentelemetry.io/otel/trace: v1.35.0 → v1.36.0
  • go.opentelemetry.io/otel: v1.35.0 → v1.36.0
  • go.yaml.in/yaml/v2: v2.4.2 → v2.4.3
  • golang.org/x/crypto: v0.36.0 → v0.45.0
  • golang.org/x/mod: v0.21.0 → v0.29.0
  • golang.org/x/net: v0.38.0 → v0.47.0
  • golang.org/x/oauth2: v0.27.0 → v0.30.0
  • golang.org/x/sync: v0.12.0 → v0.18.0
  • golang.org/x/sys: v0.31.0 → v0.38.0
  • golang.org/x/telemetry: bda5523 → 078029d
  • golang.org/x/term: v0.30.0 → v0.37.0
  • golang.org/x/text: v0.23.0 → v0.31.0
  • golang.org/x/tools: v0.26.0 → v0.38.0
  • golang.org/x/xerrors: 5ec99f8 → 9bdfabe
  • google.golang.org/genproto/googleapis/rpc: a0af3ef → 200df99
  • google.golang.org/grpc: v1.72.1 → v1.72.2
  • google.golang.org/protobuf: v1.36.5 → v1.36.8
  • gopkg.in/evanphx/json-patch.v4: v4.12.0 → v4.13.0
  • k8s.io/api: v0.34.0 → v0.35.0
  • k8s.io/apiextensions-apiserver: v0.34.0 → v0.35.0
  • k8s.io/apimachinery: v0.34.0 → v0.35.0
  • k8s.io/apiserver: v0.34.0 → v0.35.0
  • k8s.io/client-go: v0.34.0 → v0.35.0
  • k8s.io/code-generator: v0.34.0 → v0.35.0
  • k8s.io/component-base: v0.34.0 → v0.35.0
  • k8s.io/gengo/v2: 85fd79d → ec3ebc5
  • k8s.io/kms: v0.34.0 → v0.35.0
  • k8s.io/kube-openapi: f3f2b99 → 589584f
  • k8s.io/utils: 4c0f3b2 → bc988d5
  • sigs.k8s.io/json: cfa47c3 → 2d32026
Removed
  • github.com/kisielk/errcheck: v1.5.0
  • github.com/kisielk/gotool: v1.0.0
  • gopkg.in/yaml.v2: v2.4.0

New Contributors

Full Changelog: kubernetes-sigs/controller-runtime@v0.22.0...v0.23.0

Thanks to all our contributors! 😊

v0.22.5

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.22.4...v0.22.5

v0.22.4

Compare Source

What's Changed

Full Changelog: kubernetes-sigs/controller-runtime@v0.22.3...v0.22.4

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • "before 9am on monday"
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.

  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate CLI.

@scality-renovate
scality-renovate Bot requested a review from a team as a code owner June 8, 2026 12:49
@scality-renovate scality-renovate Bot added dependencies Pull requests that update a dependency file go-deps minor labels Jun 8, 2026
@scality-renovate

scality-renovate Bot commented Jun 8, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

ℹ️ Artifact update notice

File name: go.mod

In order to perform the update(s) described in the table above, Renovate ran the go get command, which resulted in the following additional change(s):

  • 4 additional dependencies were updated

Due to Go's usage of Minimal Version Selection (MVS), these packages have been updated to the minimum version available, so will still abide by minimumReleaseAge=7 days

Details:

Package Change
sigs.k8s.io/structured-merge-diff/v6 v6.3.0 -> v6.3.2-0.20260122202528-d9cc6641c482
k8s.io/apiextensions-apiserver v0.34.1 -> v0.35.0
k8s.io/apiserver v0.34.1 -> v0.35.0
k8s.io/component-base v0.34.1 -> v0.35.0

@scality-renovate
scality-renovate Bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch 3 times, most recently from dc0de30 to 86862b7 Compare June 8, 2026 14:36
@scality-renovate scality-renovate Bot changed the title chore(deps): update module sigs.k8s.io/controller-runtime to v0.24.1 chore(deps): update module sigs.k8s.io/controller-runtime to v0.23.3 Jun 8, 2026
@scality-renovate
scality-renovate Bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch 2 times, most recently from bd18dbc to 620d6c8 Compare June 8, 2026 15:21
@scality-renovate

scality-renovate Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor Author

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠️ Warning: custom changes will be lost.

@scality-renovate
scality-renovate Bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 620d6c8 to 4ddc884 Compare June 16, 2026 04:32
@scality-renovate
scality-renovate Bot force-pushed the renovate/sigs.k8s.io-controller-runtime-0.x branch from 4ddc884 to dbaf08b Compare October 19, 2026 04:20
@scality-renovate
scality-renovate Bot requested a review from a team as a code owner October 19, 2026 04:20
@github-actions

github-actions Bot commented Oct 19, 2026

Copy link
Copy Markdown

Dependency Bump Evaluation

Version change: sigs.k8s.io/controller-runtime v0.22.3 → v0.23.3 (minor)
Semver bump type: Minor (spans v0.23.0 which has breaking changes)

Changes (v0.23.0 through v0.23.3):

  • Webhooks: Generic Validator and Defaulter — WebhookManagedBy API signature changed, validator interfaces now require concrete types instead of runtime.Object
  • Dependencies: Update to k8s.io/* v1.35 (v0.35.x)
  • Events: Migration to new events.k8s.io API (RBAC update needed if using GetEventRecorderFor)
  • Client: Subresource Apply support (interface change)
  • Priority queue enabled by default
  • Bug fixes: fake client SSA, cache reader sync, embedded pointer struct panic fix, memory reduction in webhooks

Breaking changes: YES — directly affects this codebase:

  1. WebhookManagedBy API change (internal/webhook/v1alpha1/managedcrl_webhook.go:41): Current code uses ctrl.NewWebhookManagedBy(mgr).For(&ManagedCRL{}) which must change to ctrl.NewWebhookManagedBy(mgr, &ManagedCRL{})

  2. Generic CustomValidator interface (internal/webhook/v1alpha1/managedcrl_webhook.go:64,67,80,92): Current code implements webhook.CustomValidator with runtime.Object parameters. Must change to:

    • webhook.CustomValidator[*crloperatorv1alpha1.ManagedCRL]
    • ValidateCreate(ctx, obj *crloperatorv1alpha1.ManagedCRL) instead of ValidateCreate(ctx, obj runtime.Object)
    • Same for ValidateUpdate and ValidateDelete
    • The manual type assertions (obj.(*crloperatorv1alpha1.ManagedCRL)) become unnecessary

Security concerns: None — standard Kubernetes ecosystem dependency update from trusted maintainers (kubernetes-sigs)

Impact on codebase: High — the PR only updates go.mod/go.sum without adapting the webhook code in internal/webhook/v1alpha1/managedcrl_webhook.go. This will cause compilation failures.

Recommendation: BREAKING CHANGES

Notes: The webhook code must be updated to use the new generic validator interface before this can merge. The required changes are straightforward but mandatory. No event recorder usage was found, so the events API migration does not apply.

— Claude Code

@eg-ayoub
eg-ayoub self-requested a review October 19, 2026 09:04
eg-ayoub
eg-ayoub requested changes Oct 19, 2026
View reviewed changes

@eg-ayoub eg-ayoub left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

breaking. how do we fix?

@scality-renovate scality-renovate Bot changed the title chore(deps): update module sigs.k8s.io/controller-runtime to v0.23.3 chore(deps): update module sigs.k8s.io/controller-runtime to v0.23.3 - autoclosed Oct 21, 2026
@scality-renovate scality-renovate Bot closed this Oct 21, 2026
@scality-renovate
scality-renovate Bot deleted the renovate/sigs.k8s.io-controller-runtime-0.x branch October 21, 2026 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@eg-ayoub eg-ayoub eg-ayoub requested changes
@anthony-treuillier-scality anthony-treuillier-scality Awaiting requested review from anthony-treuillier-scality anthony-treuillier-scality is a code owner automatically assigned from scality/platform-dev

Assignees

No one assigned

Labels

dependencies Pull requests that update a dependency file go-deps minor

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@eg-ayoub @ezekiel-alexrod