Skip to content

CLDSRV-909: Reject CopyObject when source exceeds 5 GiB (backport)#6233

Open
tcarmet wants to merge 4 commits into
development/9.3from
bugfix/CLDSRV-909-enforce-copyobject-source-size-limit
Open

CLDSRV-909: Reject CopyObject when source exceeds 5 GiB (backport)#6233
tcarmet wants to merge 4 commits into
development/9.3from
bugfix/CLDSRV-909-enforce-copyobject-source-size-limit

Conversation

@tcarmet

@tcarmet tcarmet commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Backport of #6177 to development/9.3.

Align cloudserver's CopyObject with the AWS S3 contract by rejecting requests whose source object exceeds 5 GiB. AWS S3 returns HTTP 400 InvalidRequest ("The specified copy source is larger than the maximum allowable size for a copy source: 5368709120") and expects clients to use the multipart copy flow instead; cloudserver previously accepted these requests. The bypassMaxPutObjectSize flag still overrides the limit, matching the PutObject behavior.

The first commit is a prettier-only reformat of the two touched files and can be skipped during review; the actual change lives in the three cherry-picked commits.

@bert-e

bert-e commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Hello tcarmet,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e

bert-e commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Incorrect fix version

The Fix Version/s in issue CLDSRV-909 contains:

  • 9.4.0

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 9.3.14

  • 9.4.0

Please check the Fix Version/s of CLDSRV-909, or the target
branch of this pull request.

@codecov

codecov Bot commented Jul 21, 2026

Copy link
Copy Markdown

❌ 2 Tests Failed:

Tests completed Failed Passed Skipped
8493 2 8491 0
View the top 1 failed test(s) by shortest run time
"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With v4 signature "after each" hook for "should fail if trying to overwrite a delete marker"
Stack Traces | 0.013s run time
We encountered an internal error. Please try again.
View the full list of 1 ❄️ flaky test(s)
"after each" hook for "should fail if trying to overwrite a delete marker"::MPU with x-scal-s3-version-id header With default signature "after each" hook for "should fail if trying to overwrite a delete marker"

Flake rate in main: 90.12% (Passed 24 times, Failed 219 times)

Stack Traces | 0.015s run time
We encountered an internal error. Please try again.

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@tcarmet
tcarmet requested a review from a team July 21, 2026 21:20
@tcarmet
tcarmet marked this pull request as ready for review July 21, 2026 21:20
@tcarmet
tcarmet requested a review from a team July 21, 2026 21:44
@tcarmet

tcarmet commented Jul 21, 2026

Copy link
Copy Markdown
Contributor Author

/create_integration_branches

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants