Repository navigation
Conversation
click, hover, fill, type_text and upload_file now return an `element` field like `button "Save"`, read in the page before the action, so tool output says what was clicked instead of a bare uid. fill_form returns `elements`, drag returns `element` plus `target_element`. Best-effort: bounded to 2s, omitted on failure, never masks the action's own error. The snapshot walker's role/accname heuristics are lifted into a shared ACCNAME_HELPERS_SOURCE so both paths name elements the same way. Co-Authored-By: Claude Opus 5.5 <[email protected]>
prxref automated review: ApprovedPR: feat: action results name the element they touched (3.1.0) · files reviewed: 8 🟥 0 error · 🟧 1 warning · 🔍 0 spec · ⬜ 0 outofscope
Reviewed by prxref · model=z-ai/glm-5.3-flash · 22434 tok · 12.6s · seed=1722819217 |
…lement # Conflicts: # CHANGELOG.md # package.json # src/version.ts
|
|
||
| ## [Unreleased] | ||
|
|
||
| ## [3.1.0] - 2026-10-26 |
There was a problem hiding this comment.
🤖 🟧 [WARNING] 3.1.0 is dated before the 3.0.3 release (CHANGELOG.md:10)
The new entry is ## [3.1.0] - 2026-10-26 while the entry below it reads ## [3.0.3] - 2026-10-29; the changelog now lists the newer version with an earlier date, which will mislead release tooling and readers. One of the two dates is wrong.
Reviewed by prxref · model=z-ai/glm-5.3-flash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
A transcript of
click {uid: 9}tells a reader nothing about what was clicked. Now the result says it:{ "clicked": true, "element": "button \"Add new item\"", "x": 85.66, "y": 95.69 }What
click,hover,fill,type_text,upload_filereturnelement: a snapshot-stylerole "name"string.fill_formreturnselements(one per field,nullif unreadable);dragreturnselement(source) andtarget_elementwhentois an element.ACCNAME_HELPERS_SOURCE; the walker's generated source is identical modulo whitespace (checked againstmain).toolDocs(click, fill) and the skill's "common mistakes" line updated.Caveat
On Chrome the snapshot comes from the native AX tree while
elementuses the DOM heuristic. They agree for buttons, links, tabs and labelled inputs; exotic accname cases can differ.Verification
bun run typecheckclean;bun test1040 pass, 0 fail (14 new intest/describe-element.test.ts).bun run smoke13/13 against a live Chromium.click --uid 9→button "Add new item"(handler fired once)click --uid 8→tab "Details"click --selector #plain→div "Plain row text"fill --uid 11→textbox "Email"hover --selector a→link "Next page"uid does not resolve: 99999)callOnElementpath; unit-tested only).