Repository navigation
Fit the Paint tab's Materials section in a 1000 px dock - #1380
Merged
Merged
Conversation
saworbit
enabled auto-merge (squash)
October 21, 2026 00:26
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With only Materials open in a 1000 px dock, the Paint tab still scrolled, so finding a texture meant scrolling the tab to reach the grid.
Measured headless at 1000 px with a level open: the tab has 778 px and its content was 1092 px. The headers, hint and margins with only Materials open cost 390 px. That leaves 388 px for the section, and the four-row grid floor from #1332 is 356 px by itself. So the issue's proposal alone (fold the library buttons, move the status line) cannot make it fit. The grid's floor has to give way too.
GRID_MIN_ROWSgoes from 4 to 2. The grid still takes all the height the tab has left: two rows at 1000 px, four from 1200 px up. This trades [Paint] Let the material browser show more than two rows #1332's four rows at 1000 px for a tab that does not scroll; the grid scrolls inside itself instead.Tests in
test_dock_tab_width.gd, now on a real level with the 150 prototypes: the tab fits at 1000 px with at least two rows; a 700 px dock keeps two; the library buttons stay hidden until Material Library opens; the header reads "150 materials". The four-row test now runs at 1200 px and checks the tab does not scroll. Mutation checked: the old floor or the library rows back under the grid both fail the fit test.Docs: the lines that named the buttons' old place or the old status line, in the User Guide, Texture Materials, Prototype Textures, the smoke checklist and Data Portability.
ui_material_browser.pngretaken from this branch.Local: test_dock_tab_width 9/9, test_material (5 scripts, 154), test_dock (12 scripts, 104), test_plugin_ (18 scripts, 224), and the viewport, prefs and palette scripts, all green.
Fixes #1366