Repository navigation
Capture a structure piece selected for the User Guide - #1376
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The capture's structure shot could not hold a selected piece.
_build_structuresreturns generator ids, which are Strings, and the earlier tries handed one to_select_only(). That cleared the selection, thenEditorSelection.add_node()refused the String and the shot went out with nothing selected. Nothing in the plugin cleared it.ui_structure_pieceshot: a tread of the spiral staircase selected, the Structure section on Update with Detach beside it, and the context toolbar on one row ending in Upd and Det._structure_piece()turns a generator id into its highest piece, so the gizmo stands on something above the floor.plugin.update_overlays()before capturing. Without it the toolbar keeps its old width and stands one button wide down the viewport; filed as [Viewport] The context toolbar stays one button wide after a selection made outside the viewport #1375.ui_structure.pngis unchanged. The new image goes under "Changing a structure after you have built one" in the User Guide and in the shot table indocs/demos/README.md.Checked:
capture_ui.pyfrom the branch (the new image looked at, every other image checked out again),mkdocs build --strict, CI's two lint commands,check_script_warnings.py, uid parity, test_mcp_listener (loads the docshot) 33/33.Fixes #1370