Repository navigation
Rebuild the showcase level in metres - #1360
Merged
Merged
Conversation
The hall was laid out on the old Quake-family grid, 48 by 64 m with 26 m walls, and Run Check named its own dais steps as too steep. It is now a 12 by 16 m hall with 6 m walls on a 0.25 m grid, three 0.25 m risers to the dais, and every part in proportion, with the same colonnade, gallery, window bays and towers and the same four stages. Textures repeat once a metre, since faces project in world space (#652). A test loads the showcase and its stages and asserts Run Check reports nothing. The cameras in the stills capture and the docs capture follow the scale, and every image from the level is retaken.
saworbit
enabled auto-merge (squash)
October 20, 2026 23:02
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tools/build_showcase_scene.gdlaid the hall out on the Quake-family grid (HALF_W 24,HALF_D 32,WALL_H 26) and stacked 0.7 m dais risers, whichHFTraversalCheckrefuses against the player's 0.4 m step. The constants are now metres on a 0.25 m grid: a 12 by 16 m hall, 6 m walls, 0.5 m wall and floor thickness, 2 m sills, 5 m heads, 4 m door, 3.5 m gallery, three 0.25 m risers to the dais, 2 m towers 7.5 m tall. The colonnade, gallery, window bays, dais, towers and the four stages are unchanged in shape.One correction beyond the issue: faces project their texture in world space since #652, so
uv1_scaleis repeats per metre, not per face; the old per-face counts would have tiled a dozen times a metre on the small hall (rendered and seen). One repeat a metre reproduces the committed look, and the per-entry uv column is gone.tests/test_showcase_level_check.gdloads the showcase and its three stages with the real LevelRoot, runsvalidate_level(false)and asserts no issues, that the level fits 16 by 10 by 20 m with the floor top at y 0, and that every dais step rises within the player's step height. On the old scenes it fails with the exact "Stairs from DaisStep0 to DaisStep2 rise 0.70 m" finding.Cameras in
tools/capture_showcase.gdand the docs capture's probe and editor cameras are scaled with the level; the workshop staging constants that sit on the starter ground are left alone. The three stills and the 21 editor shots are retaken from this branch and committed.Before / After Behavior
Related Issue
Fixes #1331
Checks
test_showcase_level_check4/4 (3/4 fail on the old scenes),test_traversal_validate54/54,test_hflevel,test_reference_cleanup,test_hf_validation,test_suite_integritytools/capture_showcase.gdand the editor shots withtools/capture_ui.py, both from this branch, and looked at: hero down the colonnade to the dais, overview clearing the towers, gallery framedcheck_script_warnings.pyclean;samples/hf_demo_empty.tscnand every.hfleveluntouchedchangelog.d/, no edit to CHANGELOG.md