Skip to content
This repository was archived by the owner on Oct 16, 2026. It is now read-only.

Capture the offline routes' engine probes - #1476

Merged
saworbit merged 1 commit into
mainfrom
tools/vibe-soak-1016-probes
Oct 16, 2026
Merged

saworbit merged 1 commit into
mainfrom
tools/vibe-soak-1016-probes

Conversation

@saworbit

Copy link
Copy Markdown
Owner

The soak that gave project_set_input_action, signal_connect and scene_create a file route (#1467, #1468, #1469) settled each format question with throwaway Godot probes. This keeps them as probes, each taking its engines on the command line, and logs the session in tools/vibe/README.md.

Probe What it keeps
scene_connection_engine.py The editor's [connection] spelling for flags 2, 3 and 6 and an unbound callable, what a loaded file keeps of a bad signal, method or emitter, and connections written through the server then loaded (#1387).
scene_root_engine.py Every constructible Node class as a root-only scene against the two-line file, a root's name through Node.set_name and through a hand-written line, a MissingNode root (#1471) and a 4.7-only root on older lines (#1472).
offline_scene_create.py Twenty-six scenes written by the server with no editor, then scanned by the editor and loaded, each checked against the engine's own line, name and uid (#1380).
input_action_literal.py The server's [input] text against the engine's own route for the same events, once an engine has loaded and saved it (#1379).
ext_resource_type_engine.py How a scene names an imported PNG and WAV, and what a malformed uid beside a real path does (#1461, #1446).

I ran all five on 4.5.1, 4.6.2 and 4.7.2, and each reproduces what the session recorded. The three that drive the server find the binary the way the tests do, or take --didi.

Two things came up while making them reusable. Godot's JSON.stringify writes control characters raw and \' as an escape, so names travel as UTF-8 byte arrays. And a Windows pipe uses the console code page, so the two probes that print non-ASCII names set stdout to UTF-8.

One engine line is in the session log rather than a probe. A first --import of the connection probe's project printed ERROR: Parameter "singleton" is null. once on 4.7.2. Four reruns and a bisect of the project did not bring it back.

Tooling only, so no changelog line, as with #1232. The docs validator, the native suite, the Python suite and the test counts pass locally.

Five probes from the soak that gave project_set_input_action,
signal_connect and scene_create a file route, each turned from a
throwaway into one that takes its engines on the command line:

- scene_connection_engine.py: the editor's [connection] spelling, what a
  loaded file keeps of a bad line, and the server's lines loaded (#1387).
- scene_root_engine.py: every Node class as a root-only scene, a root's
  name, a MissingNode root (#1471) and a newer class on older lines (#1472).
- offline_scene_create.py: scenes written by the server, then scanned and
  loaded (#1380).
- input_action_literal.py: the server's [input] text against the engine's
  own route (#1379).
- ext_resource_type_engine.py: how a scene names an imported asset, and a
  malformed uid (#1461, #1446).

Each reproduces what was recorded, on 4.5.1, 4.6.2 and 4.7.2. The README
indexes them and logs the session.
@github-actions github-actions Bot added the tooling Generators, harnesses, and developer tooling label Oct 16, 2026
@saworbit
saworbit enabled auto-merge (squash) October 16, 2026 00:44
@saworbit
saworbit merged commit c77a73b into main Oct 16, 2026
26 checks passed
@saworbit
saworbit deleted the tools/vibe-soak-1016-probes branch October 16, 2026 01:10
saworbit added a commit that referenced this pull request Oct 16, 2026
The reference says what was measured on 4.5.1, 4.6.2 and 4.7.2 for the
offline signal_connect, scene_create and project_set_input_action routes.
#1476 kept the probes that measured it, so each sentence now names the one
to rerun, as SURFACE_AMENDMENTS and the developer guide already do.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

tooling Generators, harnesses, and developer tooling

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant