This repository was archived by the owner on Oct 16, 2026. It is now read-only.
Repository navigation
Capture the offline routes' engine probes - #1476
Merged
Merged
Conversation
Five probes from the soak that gave project_set_input_action, signal_connect and scene_create a file route, each turned from a throwaway into one that takes its engines on the command line: - scene_connection_engine.py: the editor's [connection] spelling, what a loaded file keeps of a bad line, and the server's lines loaded (#1387). - scene_root_engine.py: every Node class as a root-only scene, a root's name, a MissingNode root (#1471) and a newer class on older lines (#1472). - offline_scene_create.py: scenes written by the server, then scanned and loaded (#1380). - input_action_literal.py: the server's [input] text against the engine's own route (#1379). - ext_resource_type_engine.py: how a scene names an imported asset, and a malformed uid (#1461, #1446). Each reproduces what was recorded, on 4.5.1, 4.6.2 and 4.7.2. The README indexes them and logs the session.
saworbit
enabled auto-merge (squash)
October 16, 2026 00:44
saworbit
added a commit
that referenced
this pull request
Oct 16, 2026
The reference says what was measured on 4.5.1, 4.6.2 and 4.7.2 for the offline signal_connect, scene_create and project_set_input_action routes. #1476 kept the probes that measured it, so each sentence now names the one to rerun, as SURFACE_AMENDMENTS and the developer guide already do.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The soak that gave
project_set_input_action,signal_connectandscene_createa file route (#1467, #1468, #1469) settled each format question with throwaway Godot probes. This keeps them as probes, each taking its engines on the command line, and logs the session intools/vibe/README.md.scene_connection_engine.py[connection]spelling for flags 2, 3 and 6 and an unbound callable, what a loaded file keeps of a bad signal, method or emitter, and connections written through the server then loaded (#1387).scene_root_engine.pyNode.set_nameand through a hand-written line, aMissingNoderoot (#1471) and a 4.7-only root on older lines (#1472).offline_scene_create.pyinput_action_literal.py[input]text against the engine's own route for the same events, once an engine has loaded and saved it (#1379).ext_resource_type_engine.pyI ran all five on 4.5.1, 4.6.2 and 4.7.2, and each reproduces what the session recorded. The three that drive the server find the binary the way the tests do, or take
--didi.Two things came up while making them reusable. Godot's
JSON.stringifywrites control characters raw and\'as an escape, so names travel as UTF-8 byte arrays. And a Windows pipe uses the console code page, so the two probes that print non-ASCII names set stdout to UTF-8.One engine line is in the session log rather than a probe. A first
--importof the connection probe's project printedERROR: Parameter "singleton" is null.once on 4.7.2. Four reruns and a bisect of the project did not bring it back.Tooling only, so no changelog line, as with #1232. The docs validator, the native suite, the Python suite and the test counts pass locally.