Repository navigation
Name the numeric key value in input refusals - #1418
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
String keycodes were refused without the integer to send, and the documented Key reflection lookup returned nothing. Both input tools now name the event and the exact pinned enum value in the refusal. Unknown spellings point to the global enum lookup. Refused batches never reach the write or dispatch path.
The pinned reference retains global enums. Existing class records are unchanged. Retry data keeps every event in order and omits batch echoes over 1024 bytes. The schema description, Tool Reference, changelog, test inventory and offline contract snapshot are updated.
Validation: 11 focused native tests and 24 Python tests passed. The new regression fails when the fix is disabled and passes after restoration. Real editor and game probes passed on Godot 4.5.1, 4.6.2 and 4.7.2. They compare project bytes before and after refusal, read persisted numeric retries through Godot and check independent input callbacks. Documentation, inventory and offline snapshot checks passed. Live CI cases cover both keycode fields and verify that rejected batches apply nothing.
Fixes #1415