v3.3.0.3 — grep fallback --type filter never matched - #64
Merged
Conversation
Ships the last mergeable work from the May/June bot queue (#41, #37, #42, #38, #47) plus #63, which redid #43 and fixed the bug that redo exposed: the grep fallback filtered on "type":"technical" while idstack-learnings-log writes "type": "technical" via json.dumps, so --type matched nothing on any machine without python3. Landing page carries the version but no new What's-new paragraph — the fix only reaches installs without python3, too narrow to promote. Verified: smoke 371/371, integration 48/48 (25 at v3.3.0.2), setup 17/17, manifest-merge 23/23, version-classifier 27/27, plugin-status 9/9, preamble-python 6/6, mutations 14/14 guarded. Co-Authored-By: Claude Opus 5 (1M context) <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release commit for the last of the May/June bot queue.
What shipped
The bug
Deduplicating the grep fallback meant writing the first test that ever ran it. It failed immediately:
--typematched nothing idstack had written. Only reaches installs without python3, which is why it sat unnoticed — and why it's not promoted on the landing page.Coverage
test/integration-test.shwent 25 → 48 assertions. The fallback path went from zero coverage to four assertions.Open queue is now 3, all
needs-rework: #50, #54, #55.🤖 Generated with Claude Code