Repository navigation
Do not publish a release without a build and a test of the images - #52
Merged
Merged
Conversation
The workflow published the images without checking that they were ever built and tested. The workflow now has three steps that build on each other: * The gate checks that the CI workflow passed for the commit that is released. A release can only be cut from a commit that was built and tested on the branch. * The verify job builds the image of every operating system and runs the test suite against it. * The publish job builds the image for all the platforms and publishes it, it only runs when the verification passed. The release is created after the images are published, it only runs when the publication succeeded.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The workflow published the images without checking that they were ever built and tested.
The workflow now has three steps that build on each other:
The release is created after the images are published, it only runs when the publication succeeded.
The branch master is protected now, a pull request can only be merged when all the checks of the CI workflow passed.