Repository navigation
Make the path of the configuration file configurable - #49
Merged
Merged
Conversation
The path of the configuration file was hardcoded, so a custom
configuration had to be mounted on /server/doh-server.conf, which is the
path the generated configuration uses as well.
The path can now be set with the DOH_CONFIG_FILE environment variable. A
custom configuration can live in a directory of its own and is not replaced
by the generated one:
-v ./doh-server.conf:/server-custom/doh-server.conf:ro
-e DOH_CONFIG_FILE=/server-custom/doh-server.conf
The file is generated from the bundled template when it does not exist, so
the variable works without a custom configuration as well. The argument of
the server is adjusted to the path, an argument that was given on the
command line always wins.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The path of the configuration file was hardcoded, so a custom configuration had to be mounted on
/server/doh-server.conf, which is the path the generated configuration uses as well.The path can now be set with the
DOH_CONFIG_FILEenvironment variable. A custom configuration can live in a directory of its own and is not replaced by the generated one:docker run -itd --name doh-server \ -p 8053:8053 \ -v ./doh-server.conf:/server-custom/doh-server.conf:ro \ -e DOH_CONFIG_FILE=/server-custom/doh-server.conf \ satishweb/doh-serverThe file is generated from the bundled template when it does not exist, so the variable works without a custom configuration as well. The argument of the server is adjusted to the path, an argument that was given on the command line always wins.