Repository navigation
Add the environment variables for the remaining config keys - #47
Merged
Merged
Conversation
The upstream server supports more configuration keys than the ones that
were exposed. These were missing:
local_addr
cert
key
tls_client_auth
tls_client_auth_ca
They are exposed now as DOH_SERVER_LOCAL_ADDR, DOH_SERVER_CERT,
DOH_SERVER_KEY, DOH_SERVER_TLS_CLIENT_AUTH and
DOH_SERVER_TLS_CLIENT_AUTH_CA.
The certificate and the key have to be set together, the container refuses
to start when only one of them is given. The client authentication needs
the certificate authority as well.
The health check switches to https when the server runs with TLS, it reads
that from the configuration file that is in use.
The helm chart got the new variables and a scheme for the probes, the
probes are plain http and would fail against a server that runs with TLS.
The test suite starts a container with a certificate and a key and asserts
that it serves https and that the health check passes with it.
Fixes #27
The server runs as the unprivileged user of the container, so the certificate and the key have to be readable for it. The test suite now sets the mode of the files it creates accordingly and the readme documents the requirement.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The upstream server supports more configuration keys than the ones that were exposed. These were missing:
They are exposed now as
DOH_SERVER_LOCAL_ADDR,DOH_SERVER_CERT,DOH_SERVER_KEY,DOH_SERVER_TLS_CLIENT_AUTHandDOH_SERVER_TLS_CLIENT_AUTH_CA.The test suite starts a container with a certificate and a key and asserts that it serves https and that the health check passes with it.
Fixes #27