Skip to content

build(deps): update devframe to 1.2.0 - #207

Merged
erkamyaman merged 1 commit into
santoshyadavdev:mainfrom
erkamyaman:build/devframe-1.2.0
Oct 2, 2026
Merged

erkamyaman merged 1 commit into
santoshyadavdev:mainfrom
erkamyaman:build/devframe-1.2.0

Conversation

@erkamyaman

@erkamyaman erkamyaman commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator

What and why

Updates devframe and the @devframes/* packages (agentic, hub, hub-ui, vite) to ^1.2.0 in the root, the package and the Angular Native example. 1.2.0 shares an https dev server for the hub WebSocket (devframes/devframe#419), localizes dock titles and the hub UI, and always sets defaultChildId so client docks load reliably.

Our Vite plugin already handles the hub WebSocket upgrade on Vite's own HTTP server (vite.ts), so the upstream https change doesn't change its behaviour.

Closes #204

How it was verified

  • pnpm commit:check
  • pnpm format:check
  • pnpm typecheck
  • pnpm test:devtools (1158) and pnpm test:panel
  • pnpm skills:check
  • pnpm docs:build passes. No docs change, so no-docs: nothing user-facing in this repo changes.
  • pnpm extension:build: extension/ui is unchanged
  • Checked in the browser: the demo app on nx serve with the Vite plugin, the hub at /__devframes/ shows the dock rail and a live panel with no page errors

Notes for reviewers

axe still reports frame-title and region on the hub page. 1.2.0 doesn't fix those; that's #206, waiting on devframes/devframe#425.

Summary by CodeRabbit

  • Chores
    • Updated the underlying application and Angular example tooling to newer compatible releases. These updates keep the project’s supporting components aligned across the main application and example without changing documented end-user functionality.

devframe 1.2.0 shares an https dev server for the hub WebSocket, localizes dock titles and the hub UI, and always sets defaultChildId so client docks load reliably. Bumps devframe and the @devframes packages to ^1.2.0.
@erkamyaman erkamyaman added the no-docs This pull request needs no docs change (the reason is in the description) label Oct 2, 2026
@erkamyaman erkamyaman self-assigned this Oct 2, 2026
@erkamyaman erkamyaman added the no-docs This pull request needs no docs change (the reason is in the description) label Oct 2, 2026
@github-actions github-actions Bot added area: package The ng-devtools package (packages/ng-devtools) area: demo The demo apps labels Oct 2, 2026
@coderabbitai

coderabbitai Bot commented Oct 2, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Essentials

Run ID: 705a5c14-1fd2-42dc-b7ab-13ee054cf968

📥 Commits

Reviewing files that changed from the base of the PR and between 7efd4b3 and e6f08af.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (3)
  • examples/angular-native/package.json
  • package.json
  • packages/ng-devtools/package.json

Included review availability: This review used your included allowance. 1 included review remains after this review. Your included PR review attempts over the past 7 days set your current allowance at 2 reviews per hour.


📝 Walkthrough

Walkthrough

The root, Angular Native example, and ng-devtools package manifests update Devframe dependency ranges to version 1.2.0.

Changes

Devframe Dependency Updates

Layer / File(s) Summary
Update Devframe dependency ranges
package.json, examples/angular-native/package.json, packages/ng-devtools/package.json
The manifests update version ranges for devframe and related @devframes packages to ^1.2.0.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested labels: enhancement

Merge Risk: ⚪ Minimal · up to e6f08

No actionable issue is established by the supplied evidence; the dependency update is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 4 | ❓ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Linked Issues check ❓ Inconclusive The changed manifests satisfy the requested version updates in #204. The reported checks include pnpm test:devtools, pnpm test:panel, pnpm typecheck, and pnpm extension:build, and the report s… Provide reviewable evidence for the lockfile update and for the pnpm test:axe result.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main change: dependency updates to devframe version 1.2.0 and related packages.
Out of Scope Changes check ✅ Passed The reviewed changes only update devframe-related package versions in the root, packages/ng-devtools, and the Angular Native example. These changes support the dependency update requested by #204. N…
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Full details: Linked Issues check

Explanation

The changed manifests satisfy the requested version updates in #204. The reported checks include pnpm test:devtools, pnpm test:panel, pnpm typecheck, and pnpm extension:build, and the report states that packages/ng-devtools/src/vite.ts retains its behavior. The required pnpm test:axe execution is not established. The lockfile is excluded from review, so its update cannot be verified.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.


A rabbit checks the versions in a row
New Devframe numbers start to show
The manifests now point to one-two
With updated ranges throughout
The rabbit hops along, pleased with the view

Comment @coderabbitai help to get the list of available commands.

@nx-cloud

nx-cloud Bot commented Oct 2, 2026

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit e6f08af

Command Status Duration Result
nx affected -t test build ✅ Succeeded 1m 33s View ↗

💡 Verify your cache is correct by running tasks in a sandbox. Read docs ↗


☁️ Nx Cloud last updated this comment at 2026-10-02 20:35:12 UTC

@erkamyaman
erkamyaman merged commit ba918d2 into santoshyadavdev:main Oct 2, 2026
9 of 10 checks passed
@erkamyaman
erkamyaman deleted the build/devframe-1.2.0 branch October 2, 2026 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: demo The demo apps area: package The ng-devtools package (packages/ng-devtools) enhancement no-docs This pull request needs no docs change (the reason is in the description)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

deps: update devframe to 1.2.0

1 participant