-
-
Notifications
You must be signed in to change notification settings - Fork 8
Hub page fails axe: unnamed dock iframe and no landmarks #206
Copy link
Copy link
Open
Labels
area: accessibilityAccessibility of the panel and the docsAccessibility of the panel and the docsbugSomething is broken or shows wrong dataSomething is broken or shows wrong datadevframe: bugA bug in devframe that affects this projectA bug in devframe that affects this projectdevframe: has PRA fix is open upstream in devframeA fix is open upstream in devframestate: blockedWaiting on something outside this issueWaiting on something outside this issue
Description
Activity
Metadata
Metadata
Assignees
Labels
area: accessibilityAccessibility of the panel and the docsAccessibility of the panel and the docsbugSomething is broken or shows wrong dataSomething is broken or shows wrong datadevframe: bugA bug in devframe that affects this projectA bug in devframe that affects this projectdevframe: has PRA fix is open upstream in devframeA fix is open upstream in devframestate: blockedWaiting on something outside this issueWaiting on something outside this issue
The standalone hub page (
/__devframes/) has two axe violations, in both light and dark:frame-title: the dock iframe has no accessible name.landmark-one-main/region: the page content is not inside any landmark.Both come from
@devframes/hub-ui, not from our panel. The fix is upstream in devframes/devframe#425: each dock iframe gets its localized dock title, and the dock list and content area becomenavandmainlandmarks. Checked with axe on the hub-ui playground: both violations are gone with the change.To close this: once devframe#425 is released, bump
@devframes/*here and re-run axe on/__devframes/.