Skip to content

Support GitHub App auth - #40

Merged
lkubb merged 1 commit into
mainfrom
tests-updates
Oct 16, 2026
Merged

lkubb merged 1 commit into
mainfrom
tests-updates

Conversation

@lkubb

@lkubb lkubb commented Oct 16, 2026

Copy link
Copy Markdown
Member

What does this PR do?

Adds support for authentication via GitHub App credentials directly (AppID/ClientID + private key), without needing actions/create-github-app-token or similar.

Merge requirements satisfied?

[NOTICE] Bug fixes or new features require tests.

Commits signed with GPG?

Yes

@codecov

codecov Bot commented Oct 16, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 97.44186% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 95.90%. Comparing base (5ae9cd8) to head (9de9bf8).

Files with missing lines Patch % Lines
tests/support/github/base.py 84.31% 5 Missing and 3 partials ⚠️
tests/support/github/routes/app.py 90.32% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #40      +/-   ##
==========================================
+ Coverage   95.83%   95.90%   +0.07%     
==========================================
  Files         139      143       +4     
  Lines        8385     8799     +414     
  Branches      618      647      +29     
==========================================
+ Hits         8036     8439     +403     
- Misses        296      303       +7     
- Partials       53       57       +4     
Flag Coverage Δ
Linux 95.90% <97.44%> (+0.07%) ⬆️
macOS 95.90% <97.44%> (+0.07%) ⬆️
project 93.21% <100.00%> (+0.18%) ⬆️
py310 87.23% <91.39%> (+0.20%) ⬆️
py311 87.23% <91.39%> (+0.20%) ⬆️
py314 95.86% <97.43%> (+0.07%) ⬆️
salt_3006_27 87.23% <91.39%> (+0.20%) ⬆️
salt_3008_2 95.86% <97.43%> (+0.07%) ⬆️
tests 97.44% <96.74%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkubb
lkubb merged commit ae9ff58 into main Oct 16, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant