Skip to content

Cleanup and coverage - #34

Merged
lkubb merged 3 commits into
mainfrom
tests-updates
Oct 14, 2026
Merged

lkubb merged 3 commits into
mainfrom
tests-updates

Conversation

@lkubb

@lkubb lkubb commented Oct 14, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Cleans up recent additions and increases their test coverage

What issues does this PR fix or reference?

Merge requirements satisfied?

Commits signed with GPG?

Yes

@codecov

codecov Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.19165% with 31 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.64%. Comparing base (b293044) to head (2d8d8fd).
⚠️ Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/saltext/github/states/github_org.py 96.03% 3 Missing and 2 partials ⚠️
src/saltext/github/resources/github/states/repo.py 60.00% 4 Missing ⚠️
src/saltext/github/utils/gh/client.py 93.93% 2 Missing and 2 partials ⚠️
.../saltext/github/resources/github/states/actions.py 76.92% 3 Missing ⚠️
src/saltext/github/utils/gh/resource.py 66.66% 3 Missing ⚠️
...ltext/github/resources/github/states/deploy_key.py 80.00% 2 Missing ⚠️
...text/github/resources/github/states/environment.py 80.00% 2 Missing ⚠️
...rc/saltext/github/resources/github/states/label.py 80.00% 2 Missing ⚠️
...rc/saltext/github/resources/github/states/pages.py 80.00% 2 Missing ⚠️
.../saltext/github/resources/github/states/ruleset.py 80.00% 2 Missing ⚠️
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #34      +/-   ##
==========================================
- Coverage   97.29%   96.64%   -0.65%     
==========================================
  Files         106      122      +16     
  Lines        7093     7338     +245     
  Branches      513      522       +9     
==========================================
+ Hits         6901     7092     +191     
- Misses        156      207      +51     
- Partials       36       39       +3     
Flag Coverage Δ
Linux 96.64% <96.19%> (-0.65%) ⬇️
macOS 96.64% <96.19%> (-0.65%) ⬇️
project 95.29% <94.09%> (-1.72%) ⬇️
py310 89.79% <96.19%> (-0.41%) ⬇️
py311 89.79% <96.19%> (-0.41%) ⬇️
py314 96.60% <96.18%> (-0.66%) ⬇️
salt_3006_27 89.79% <96.19%> (-0.41%) ⬇️
salt_3008_2 96.60% <96.18%> (-0.66%) ⬇️
tests 97.41% <99.38%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkubb
lkubb marked this pull request as ready for review October 14, 2026 10:13
@lkubb
lkubb merged commit 4f10073 into main Oct 14, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant