Skip to content

Add separate and modern github_org/github_repo modules - #32

Merged
lkubb merged 6 commits into
mainfrom
utils-refactor
Oct 13, 2026
Merged

lkubb merged 6 commits into
mainfrom
utils-refactor

Conversation

@lkubb

@lkubb lkubb commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

  • Deprecates all functions in the current catch-all github module (no warnings yet, just doc notes)
  • Adds two replacement modules: github_org and github_repo with more ergonomic interfaces, correctly named functions and without legacy cruft.
  • Adds support for more configs/entities, which we need to automate the salt-extensions org
  • Allows to override a profile-configured owner (previously org_name, alias is kept) anywhere and adds support for user accounts to be specified there. Also defaults it to the user account associated with the profile's token.
  • Adds config topic to docs and a bit nicer landing page

Merge requirements satisfied?

Commits signed with GPG?

Yes

@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.09497% with 67 lines in your changes missing coverage. Please review.
✅ Project coverage is 98.11%. Comparing base (fdbfb81) to head (1f1e5cc).

Files with missing lines Patch % Lines
src/saltext/github/states/github_repo.py 93.85% 28 Missing and 2 partials ⚠️
src/saltext/github/states/github_org.py 92.06% 14 Missing and 1 partial ⚠️
tests/support/github/entities.py 96.69% 6 Missing and 1 partial ⚠️
src/saltext/github/utils/gh/repos.py 90.38% 4 Missing and 1 partial ⚠️
tests/support/github/state.py 95.31% 1 Missing and 2 partials ⚠️
src/saltext/github/modules/github_org.py 97.77% 1 Missing and 1 partial ⚠️
src/saltext/github/utils/gh/environments.py 93.75% 1 Missing and 1 partial ⚠️
src/saltext/github/utils/gh/profile.py 94.87% 2 Missing ⚠️
src/saltext/github/utils/gh/client.py 96.55% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   96.69%   98.11%   +1.41%     
==========================================
  Files          50       97      +47     
  Lines        3752     6941    +3189     
  Branches      332      494     +162     
==========================================
+ Hits         3628     6810    +3182     
- Misses         87      101      +14     
+ Partials       37       30       -7     
Flag Coverage Δ
Linux 98.11% <98.09%> (+1.41%) ⬆️
macOS 98.11% <98.09%> (+1.41%) ⬆️
project 97.62% <95.68%> (-0.86%) ⬇️
py310 90.86% <92.72%> (+3.23%) ⬆️
py311 90.86% <92.72%> (+3.23%) ⬆️
py314 98.09% <98.08%> (+1.44%) ⬆️
salt_3006_27 90.86% <92.72%> (+3.23%) ⬆️
salt_3008_2 98.09% <98.08%> (+1.44%) ⬆️
tests 98.36% <99.54%> (+2.57%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkubb
lkubb merged commit 1dfcc1f into main Oct 13, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant