Skip to content

Rename utils.github package to utils.gh - #31

Merged
lkubb merged 1 commit into
mainfrom
tests-updates
Oct 12, 2026
Merged

lkubb merged 1 commit into
mainfrom
tests-updates

Conversation

@lkubb

@lkubb lkubb commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

Renames the new saltext.github.utils.github module to saltext.github.utils.gh:
Pylint can resolve absolute github (PyGithub) imports to the relative package instead, causing bogus errors.

CI is currently failing because of that, not sure why it wasn't caught in the PR checks.

Merge requirements satisfied?

[NOTICE] Bug fixes or new features require tests.

Commits signed with GPG?

Yes

Pylint can resolve absolute `github` (PyGithub) imports to the
relative package instead, causing bogus errors.
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.69%. Comparing base (85ddda9) to head (3cc236b).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   97.06%   96.69%   -0.37%     
==========================================
  Files          37       50      +13     
  Lines        3573     3752     +179     
  Branches      335      332       -3     
==========================================
+ Hits         3468     3628     +160     
- Misses         68       87      +19     
  Partials       37       37              
Flag Coverage Δ
Linux 96.69% <100.00%> (-0.37%) ⬇️
macOS 96.69% <100.00%> (-0.37%) ⬇️
project 98.48% <100.00%> (-1.52%) ⬇️
py310 87.63% <100.00%> (+0.08%) ⬆️
py311 87.63% <100.00%> (+0.08%) ⬆️
py314 96.64% <100.00%> (-0.37%) ⬇️
salt_3006_27 87.63% <100.00%> (+0.08%) ⬆️
salt_3008_2 96.64% <100.00%> (-0.37%) ⬇️
tests 95.79% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkubb
lkubb merged commit 931764e into main Oct 12, 2026
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant