Repository navigation
Rename utils.github package to utils.gh - #31
Merged
Merged
Conversation
Pylint can resolve absolute `github` (PyGithub) imports to the relative package instead, causing bogus errors.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 97.06% 96.69% -0.37%
==========================================
Files 37 50 +13
Lines 3573 3752 +179
Branches 335 332 -3
==========================================
+ Hits 3468 3628 +160
- Misses 68 87 +19
Partials 37 37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Renames the new
saltext.github.utils.githubmodule tosaltext.github.utils.gh:Pylint can resolve absolute
github(PyGithub) imports to the relative package instead, causing bogus errors.CI is currently failing because of that, not sure why it wasn't caught in the PR checks.
Merge requirements satisfied?
[NOTICE] Bug fixes or new features require tests.
Commits signed with GPG?
Yes