Skip to content

Refactor logic into entity-linked utils modules - #30

Merged
lkubb merged 3 commits into
mainfrom
utils-refactor
Oct 12, 2026
Merged

lkubb merged 3 commits into
mainfrom
utils-refactor

Conversation

@lkubb

@lkubb lkubb commented Oct 12, 2026 •

Copy link
Copy Markdown
Member

What does this PR do?

  • Prepares resource modules and entity-specific modules. Nearly backwards-compatible, just changes some outputs and wraps all PyGithub errors in CommandExecutionErrors.
  • Replaces noise log.exception calls with log.error(err, exc_info_on_loglevel=logging.debug) ones that only print the traceback on debug level
  • Also renders SDB uris in profile config values on access, meaning profiles sourced from non-config locations can still include sdb uris

Merge requirements satisfied?

Commits signed with GPG?

Yes

lkubb added 3 commits October 12, 2026 13:44
Some exceptions are expected, e.g. during state module rendering. You
can still view the verbose log at debug level
This makes sources other than the minion config work with sdb:// URI
@codecov

codecov Bot commented Oct 12, 2026 •

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 96.69%. Comparing base (85ddda9) to head (5f7db78).

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #30      +/-   ##
==========================================
- Coverage   97.06%   96.69%   -0.37%     
==========================================
  Files          37       50      +13     
  Lines        3573     3752     +179     
  Branches      335      332       -3     
==========================================
+ Hits         3468     3628     +160     
- Misses         68       87      +19     
  Partials       37       37              
Flag Coverage Δ
Linux 96.69% <100.00%> (-0.37%) ⬇️
macOS 96.69% <100.00%> (-0.37%) ⬇️
project 98.48% <100.00%> (-1.52%) ⬇️
py310 87.63% <100.00%> (+0.08%) ⬆️
py311 87.63% <100.00%> (+0.08%) ⬆️
py314 96.64% <100.00%> (-0.37%) ⬇️
salt_3006_27 87.63% <100.00%> (+0.08%) ⬆️
salt_3008_2 96.64% <100.00%> (-0.37%) ⬇️
tests 95.79% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@lkubb
lkubb merged commit dd71e8f into main Oct 12, 2026
16 checks passed
@lkubb
lkubb deleted the utils-refactor branch October 12, 2026 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant