[TECH DEBT] Need tests for existing modules #9

Activity

1. nicholasmhughes

   added

   good first issueGood for newcomersGood for newcomers

   help wantedExtra attention is neededExtra attention is needed

   on Jan 13, 2024
2. vipermark7 commented on Feb 7, 2024

   

   vipermark7

   on Feb 7, 2024

   Last edited by vipermark7

   More actions

   Interested in taking this on! I'll start with the utils/ folder

   👍React with 👍1Reacted by Nicholas Hughes
3. vipermark7 commented on Feb 7, 2024

   

   vipermark7

   on Feb 7, 2024

   Last edited by vipermark7

   More actions

   Would we want to use PyTest for this?

   I'm unsure what the wider Python community uses. I think it would be a good option since in seems to come with handy mocking features :)
4. nicholasmhughes commented on Feb 7, 2024

   

   nicholasmhughes

   on Feb 7, 2024

   MemberAuthor

   More actions

   Hello @vipermark7 ! Yes, the Salt Extensions expect to use nox to call pytest so the tests should be written in that fashion. You can look at some of the other Extensions which have tests for examples on how to structure them. If you have any additional questions, feel free to ask!

   👍React with 👍1Reacted by Shaffan
5. vipermark7 commented on Feb 7, 2024

   

   vipermark7

   on Feb 7, 2024

   More actions

   I got a new unit test to pass locally! I thinkk I'll need write access to push it to my new branch though
6. nicholasmhughes commented on Feb 7, 2024

   

   nicholasmhughes

   on Feb 7, 2024

   MemberAuthor

   More actions

   Great! Regarding contribution workflow, we use the Fork-and-Branch Workflow that is prevalent in OSS. So, you should be able to fork the repo, create a branch in your fork to hold and changes, and then open a PR to merge your branch into main back in this repository.
7. vipermark7 commented on Feb 7, 2024

   

   vipermark7

   on Feb 7, 2024 via email

   More actions

   Oh, OK, thanks! That occurred to me as soon as I posted my comment x(

   …

   On Wed, Feb 7, 2024, 3:07 PM Nicholas Hughes ***@***.***> wrote: Great! Regarding contribution workflow, we use the Fork-and-Branch Workflow <https://blog.scottlowe.org/2015/01/27/using-fork-branch-git-workflow/> that is prevalent in OSS. So, you should be able to fork the repo, create a branch in your fork to hold and changes, and then open a PR to merge your branch into main back in this repository. — Reply to this email directly, view it on GitHub <#9 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACKMZRFEX44UGIVXAG7AUBLYSPNJFAVCNFSM6AAAAABBZASVNWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTSMZSG44DEOJZGI> . You are receiving this because you were mentioned.Message ID: ***@***.***>
8. nicholasmhughes

   assigned

   vipermark7

   on Feb 14, 2024
9. lkubb

   linked a pull request that will close this issueModernize the extension and add a comprehensive test suite #28on Oct 13, 2026
10. lkubb commented on Oct 13, 2026

    

    lkubb

    on Oct 13, 2026

    Member

    More actions

    This has been implemented in #28
11. lkubb

    closed this as completedon Oct 13, 2026