Repository navigation
Remove the comparison container's anonymous volumes in docker_container.running - #27
Open
rstarkey-block wants to merge 1 commit into
Open
rstarkey-block wants to merge 1 commit into
rstarkey-block wants to merge 1 commit into
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #27 +/- ##
==========================================
+ Coverage 42.66% 42.90% +0.23%
==========================================
Files 25 25
Lines 6495 6524 +29
Branches 1120 1122 +2
==========================================
+ Hits 2771 2799 +28
Misses 3469 3469
- Partials 255 256 +1
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On every run where a container already exists with an unchanged image,
docker_container.runningcreates a temporary container to compare against and then removes it without its volumes, so an image that declares aVOLUMEleaks one anonymous volume per run. This removes the temporary container's volumes along with it._delete_temp_containercallsdocker.rm(temp_container_name, volumes=True). Volumes of replaced or removed containers are left alone, since they may hold data.VOLUME, two unchanged runs, no new dangling volume) and a changelog fragment._replacefix is tracked in #25.