Skip to content

Use extension's own copy of dockermod utils - #26

Merged
ycedres merged 1 commit into
mainfrom
bugfix/19/use-own-extension-utils
Oct 13, 2026
Merged

ycedres merged 1 commit into
mainfrom
bugfix/19/use-own-extension-utils

Conversation

@ycedres

@ycedres ycedres commented Oct 8, 2026

Copy link
Copy Markdown
Contributor

What does this PR do?

Refactors parts of the code where the utils.dockermod module was being imported from the Salt code instead of from importing it from the extension's code.

What issues does this PR fix or reference?

Fixes: #19

Merge requirements satisfied?

[NOTICE] Bug fixes or new features require tests.

Commits signed with GPG?

Yes

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@ycedres
ycedres requested a review from m-czernek October 8, 2026 08:33
@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 24.56140% with 43 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.66%. Comparing base (0fe7109) to head (133d0bf).

Files with missing lines Patch % Lines
tests/unit/utils/test_dockermod.py 4.44% 43 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #26      +/-   ##
==========================================
+ Coverage   41.90%   42.66%   +0.75%     
==========================================
  Files          26       25       -1     
  Lines        6629     6495     -134     
  Branches     1146     1120      -26     
==========================================
- Hits         2778     2771       -7     
+ Misses       3601     3469     -132     
- Partials      250      255       +5     
Flag Coverage Δ
Linux 42.64% <24.56%> (+0.75%) ⬆️
project 38.46% <100.00%> (+0.70%) ⬆️
py310 42.60% <24.56%> (+0.75%) ⬆️
py311 42.60% <24.56%> (+0.75%) ⬆️
py314 42.60% <24.56%> (+0.75%) ⬆️
salt_3006_27 42.60% <24.56%> (+0.75%) ⬆️
salt_3008_2 42.60% <24.56%> (+0.75%) ⬆️
tests 50.86% <4.44%> (+1.31%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ycedres
ycedres merged commit 792add6 into main Oct 13, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TECH DEBT] Modules and states use Salt's salt.utils.dockermod instead of the extension's own copy

2 participants