Skip to content

Do not hardcode cmd - #20

Open
m-czernek wants to merge 1 commit into
mainfrom
bugfix/2/test
Open

m-czernek wants to merge 1 commit into
mainfrom
bugfix/2/test

Conversation

@m-czernek

Copy link
Copy Markdown
Contributor

What does this PR do?

Do not hardcode cmd when starting a new container.

What issues does this PR fix or reference?

Fixes: #2

Previous Behavior

Remove this section if not relevant

New Behavior

Remove this section if not relevant

Merge requirements satisfied?

[NOTICE] Bug fixes or new features require tests.

Commits signed with GPG?

Yes/No

Please review Salt's Contributing Guide for best practices.

See GitHub's page on GPG signing for more information about signing commits with GPG.

@codecov

codecov Bot commented Sep 22, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 6 lines in your changes missing coverage. Please review.
✅ Project coverage is 42.08%. Comparing base (cebd4c0) to head (f010a3e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/saltext/dockermod/modules/dockermod.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #20      +/-   ##
==========================================
- Coverage   42.10%   42.08%   -0.03%     
==========================================
  Files          26       26              
  Lines        6545     6549       +4     
  Branches     1138     1140       +2     
==========================================
  Hits         2756     2756              
- Misses       3542     3546       +4     
  Partials      247      247              
Flag Coverage Δ
Linux 42.06% <0.00%> (-0.03%) ⬇️
project 37.67% <0.00%> (-0.04%) ⬇️
py310 42.02% <0.00%> (-0.03%) ⬇️
py311 42.02% <0.00%> (-0.03%) ⬇️
py314 42.02% <0.00%> (-0.03%) ⬇️
salt_3006_27 42.02% <0.00%> (-0.03%) ⬇️
salt_3008_2 42.02% <0.00%> (-0.03%) ⬇️
tests 50.37% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@m-czernek
m-czernek marked this pull request as ready for review September 25, 2026 08:59

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] sls build module is broken when CMD base image matters

1 participant